After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 349756 - Confusing Errormessage while opening Logfile
Confusing Errormessage while opening Logfile
Status: RESOLVED FIXED
Product: gnome-utils
Classification: Deprecated
Component: logview
2.14.x
Other All
: Normal minor
: ---
Assigned To: gnome-utils Maintainers
gnome-utils Maintainers
: 365058 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-08-03 06:02 UTC by Markus Keil
Modified: 2008-12-24 08:50 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
patch to add better error messages (3.66 KB, patch)
2007-09-23 18:37 UTC, mnvl16
none Details | Review

Description Markus Keil 2006-08-03 06:02:18 UTC
While opening a Logfile which is read-proteced by permissions for the user running gnome-system-log, the program says "<file> is not a Logfile".
The User should be informed that he is not allowed to read the logfile he want to open.

Other information:
Comment 1 Teppo Turtiainen 2007-07-07 11:40:50 UTC
*** Bug 365058 has been marked as a duplicate of this bug. ***
Comment 2 mnvl16 2007-09-23 18:37:29 UTC
Created attachment 96068 [details] [review]
patch to add better error messages

This patch fixes the bug, by separating three different error cases and giving corresponding messages. This patch still requires that the new strings involved be translated into further languages.
Comment 3 mnvl16 2007-09-23 18:41:02 UTC
(In reply to comment #2)
> Created an attachment (id=96068) [edit]
> patch to add better error messages
> 
> This patch fixes the bug, by separating three different error cases and giving
> corresponding messages. This patch still requires that the new strings involved
> be translated into further languages.
> 

I should have specified that although this diff was taken against version 2.14 sources, I have edited the patch manually so that it can be applied to version 2.19. (There were very small changes to the source file between these two versions).
Yours, Jack
Comment 4 Cosimo Cecchi 2008-12-23 14:08:50 UTC
I'm not sure this is an issue anymore with Logview trunk, as it has been rewritten and ported to GIO. I'll have a look at this later.
Comment 5 Cosimo Cecchi 2008-12-24 08:50:16 UTC
Fixed in trunk now.

2008-12-24  Cosimo Cecchi  <cosimoc@gnome.org>

	* logview-log.c (log_load):
	* logview-log.h:
	Set a meaningful error message if we can't read from the log file
	(#349756).