After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 348853 - Errors in .desktop file break bug-buddy support
Errors in .desktop file break bug-buddy support
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
HEAD
Other All
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks: 348827
 
 
Reported: 2006-07-26 20:06 UTC by Olav Vitters
Modified: 2006-08-11 05:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (843 bytes, patch)
2006-07-27 02:25 UTC, James "Doc" Livingston
none Details | Review
rhythmbox.desktop.in.in (674 bytes, application/octet-stream)
2006-08-04 06:06 UTC, James "Doc" Livingston
  Details

Description Olav Vitters 2006-07-26 20:06:04 UTC
The rhythmbox  desktop/server file has the following problems:
 - Lacks (valid?) X-GNOME-Bugzilla-Component (make sure to get the case exactly
right)
 - Lacks version information

Currently contains: general. Should be general (or just rename the component).

Full reason why this is needed:

Starting with Bug-Buddy 2.15.0 all programs wanting to make use of Bug-Buddy must have a .desktop file. Also the .desktop file must contain a few Bug-Buddy headers.

These are:
X-GNOME-Bugzilla-Bugzilla=GNOME <-- Mandatory
X-GNOME-Bugzilla-Product=XXX <--Mandatory
X-GNOME-Bugzilla-Component=YYY <-- Mandatory
X-GNOME-Bugzilla-OtherBinaries=ZZZ <-- Optional, only if you
application has several binaries
X-GNOME-Bugzilla-Version=X.Y.Z <-- Optional, but highly recommended. This should need expansion from configure script, so if you want this you need a
application.desktop.in.in to expand here @VERSION@
(application.desktop.in is used by intltool for translations).

This headers have actually been in use since 2002, except that Bug-Buddy 2.15.0 will now require:
a) A .desktop file containing at least the mandatory information
b) Given product and component MUST exist on bugzilla.gnome.org

Having the X-GNOME-Bugzilla-Version is optional, but highly recommended. The server will automatically change versions like 2.15.90 to 2.15.x, so this doesn't have to be changed in the .desktop file. I recommend keeping the real version in the desktop file as I might put this in a comment.

Users will only be able to fill in their email address and a 'What were you doing when the application crashed?'. Version information will not be possible to select anymore. This is why having the X-GNOME-Bugzilla-Version is highly recommended.

If you want Bug-Buddy support, but do not want your application to show up in the menus, use the following .desktop header:
NoDisplay=true
Comment 1 James "Doc" Livingston 2006-07-27 02:25:12 UTC
Created attachment 69707 [details] [review]
patch

I think this should fix it.

Is "X-GNOME-Bugzilla-OtherBinaries=rhythmbox-client;rhythmbox-metadata" correct for multiple extra binaries, or should I use two lines?
Comment 2 Alex Lancaster 2006-07-31 09:08:25 UTC
(In reply to comment #1)
> Created an attachment (id=69707) [edit]
> patch
> 
> I think this should fix it.

That patch doesn't touch rhythmbox.desktop.in and doesn't contain:

X-GNOME-Bugzilla-Version=@VERSION@



Comment 3 James "Doc" Livingston 2006-08-04 06:06:42 UTC
Created attachment 70183 [details]
rhythmbox.desktop.in.in

Oops, I should probably have actually attached the file.
Comment 4 James "Doc" Livingston 2006-08-11 05:33:09 UTC
Committed to cvs with a small build fix. This should have fixed the problem, but feel free to re-open if I've missed something.