GNOME Bugzilla – Bug 348308
bug-buddy support
Last modified: 2006-09-26 16:15:19 UTC
beagle-search.desktop does not contain the X-GNOME-Bugzilla entries that are necessary to allow bug-buddy to support it.
beagle-settings.desktop too
Unfortunately, because beagle is written in mono, it would not support bug buddy anyways. However, I think that might change with a SoC project or something (read it somewhere, can't remember). But yeah, the bugbuddy folks will be adding mono support and the like soon enough. Regardless, here is a patch so that bugbuddy will come up, even if it can't get a backtrace.... Hopefully we can do some sort of component system, I'm just thinking Frontend/Daemon, but I'm open to suggestions.
Created attachment 69385 [details] [review] Adds entries to .desktop files for bugbuddy integration
Let's just go with the "general" component for right now, and we'll segment it up better a little bit later. Once that's fixed, please commit.
IMO this patch shouldn't be committed as-is. It hard-codes the version within the .desktop file. This should be generated from @VERSION@ (or whatever macro is used within Beagle for that). Steps usually to do this usually are: 1.- remove .desktop.in file from cvs 2.- add .desktop.in.in with the X-Gnome-Bugzilla-Version=@VERSION@ 3.- remove .desktop.in entry from po/POTFILES.in 4.- add .desktop.in.in entry in po/POTFILES.in 5.- replace .desktop entry in AC_OUTPUT in configure.in for .desktop.in entry
Ok, I can play with this later, if Joe's cool with the build system change. In general, I'm pretty unfamiliar with this type of think (I'm still just figuring out make ;) ) So I'll do my best, but does every file with a .in extension get processed?
I am; the version number thing didn't even register with me, but Olav is right. We're already doing these type of version substitutions in some files. Take a look at how we deal with beagle-0.0.pc.in for an example of how to do it.
Created attachment 72117 [details] [review] create .desktop.in.in files Ok, this is a little complicated, but its the only way I could see that got it to work...
The Makefile.am changes shouldn't be necessary, just add the beagle-search.desktop.in to the files that are output in AC_OUTPUT() in configure.in
Created attachment 73183 [details] [review] Bug Buddy integration Ok, this does just that, let me know what you think.
The new .in.in files need to be included in EXTRA_DIST in the respective Makefile.am files. Sorry I didn't make that more clear in my last comment.
No worries, just me overlooking :-/. Added them and committed.