After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 348184 - Unfuck ->video_width (and co.)
Unfuck ->video_width (and co.)
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: xine-lib backend
1.5.x
Other Linux
: Normal normal
: ---
Assigned To: Maintainer alias for xine-lib component of Totem
Maintainer alias for xine-lib component of Totem
Depends on:
Blocks:
 
 
Reported: 2006-07-20 20:47 UTC by Bastien Nocera
Modified: 2006-08-03 14:31 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Bastien Nocera 2006-07-20 20:47:40 UTC
This used to be registered properly when we used xine-lib to display the logo, but not anymore since we display the logo ourselves.
Comment 1 Bastien Nocera 2006-07-20 20:52:46 UTC
Easy way to test:
1. Launch Totem
2. Press "1"
3. In bacon_video_widget_set_scale_ratio(), bvw->priv->video_width contains pure garbage.

Note that we shouldn't even allow that to be launched in logo mode.
Comment 2 Bastien Nocera 2006-08-03 14:31:27 UTC
Committed to HEAD

2006-08-03  Bastien Nocera  <hadess@hadess.net>

        * src/backend/bacon-video-widget-xine.c:
        (bacon_video_widget_set_logo_mode),
        (bacon_video_widget_set_scale_ratio): Make sure we can't call
        _set_scale_ratio when the logo mode is on, but still make sure
        ->video_width and ->video_height are set (Closes: #348184)

I also backported all those other logo related fixes to gnome-2-14