After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 347972 - [cdiocddasrc] core dumps if device is not found
[cdiocddasrc] core dumps if device is not found
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other opensolaris
: Normal normal
: 0.10.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-07-19 00:55 UTC by Brian Cameron
Modified: 2006-07-19 07:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to remove assert (418 bytes, patch)
2006-07-19 00:56 UTC, Brian Cameron 		committed Details | Review

Description Brian Cameron 2006-07-19 00:55:44 UTC 
I notice that if the device passed to CDDA is not found, it triggers an assert in the close function, causing the program to crash.  Programs like gnome-cd work better if they don't crash, since the device can be changed in the Preferences.
Attaching patch to remove the assert, which I don't think really adds any value.
Comment 1 Brian Cameron 2006-07-19 00:56:19 UTC 
Created attachment 69150 [details] [review]
patch to remove assert
Comment 2 Tim-Philipp Müller 2006-07-19 07:37:02 UTC 
Thanks for the patch, but I've already removed this assert in CVS last week when you mentioned it on IRC:


  2006-07-11  Tim-Philipp Müller  <tim at centricular dot net>

        * ext/cdio/gstcdiocddasrc.c: (gst_cdio_cdda_src_close):
          Remove g_assert that shouldn't be there.


> Programs like gnome-cd work better if they don't crash

No kidding :)