After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 347931 - EBook async API is has weird return type
EBook async API is has weird return type
Status: RESOLVED OBSOLETE
Product: evolution-data-server
Classification: Platform
Component: Contacts
1.8.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2006-07-18 15:21 UTC by Ross Burton
Modified: 2013-09-10 13:42 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Ross Burton 2006-07-18 15:21:20 UTC
The EBook async API is of this form:

guint
e_book_async_get_contact (EBook                 *book,
			  const char            *id,
			  EBookContactCallback   cb,
			  gpointer               closure)

For a long time I thought that the guint return value was an operation ID.  Then the API docs were updated and I see this on every async method:

 * Return value: %TRUE if the operation was started, %FALSE otherwise.

Surely the return value of the async method calls should be a gboolean...
Comment 1 iain 2006-07-18 15:24:25 UTC
Or alternatively the API could be extended so that they are operation IDs and e_book_cancel would take them and cancel a specified operation rather than just pending ones.

But Ross's suggestion is the easier option :)
Comment 2 Ross Burton 2007-05-25 16:49:32 UTC
The correct return type, gboolean, is a typedef of gint, so I don't think this would cause any ABI breakages.
Comment 3 Matthew Barnes 2008-03-11 00:59:03 UTC
Bumping version to a stable release.
Comment 4 Matthew Barnes 2012-10-10 02:52:12 UTC
EBook is deprecated in favor of EBookClient, which has a proper async API.

Closing this OBSOLETE.