GNOME Bugzilla – Bug 347678
Use meaningful timestamps for GimpPaintCore stroking
Last modified: 2018-05-24 11:52:50 UTC
If I try to stroke the selection with the ink tool active, it acts like the pen size is massive -- no matter if I set it as low as 0.2. This is unlike the behaviour produced by selecting the menu item <Image>/Edit/Stroke Selection and picking Ink tool to stroke with. I expected it to be identical to <Image/Edit/Stroke Selection . Easily reproduced: 1. make a new image 2. select an area (curved shape makes the error more blatant) 3. select ink tool 4. call gimp-edit-stroke on the first layer
That's simply the result expected when pressing the brush tip onto the canvas with maximum pressure in infinitely short time and then painting with infinite speed ;) The actual bug is in app/paint/gimppaintcore-stroke.c which always passes 0 as time to gimp_paint_core_paint(). The Stroking functions in gimppaintcore-stroke.c should probably have a "speed" argument and/or GimpCoords should get a time field. WRT the immediate full pressure, that's exactly the same result as when using the ink tool with the mouse instead of a tablet. Varying pressure can be used when stroking a GimpVectors, but I think we have no choice but stroking a selection with the default pressure (== full pressure).
"that's exactly the same result as when using the ink tool with the mouse" -- no, it's not. I can draw with the mouse+ink tool fine, i don't get grossly oversized paint strokes whether I use speed-sensitivity with it or not. Mouse gives immediate full pressure, stroking gives immediately absurdly-overfull pressure. The way I figure it, if i set the size to 0.5, the maximum stroke radius should be 0.5 -- not ~8 ! In fact the thickness of the stroke is unaffected by the size option when using gimp-edit-stroke.
Well, did you look at the code? There is no such thing as overfull pressure, and stroking very fast with the mouse *does* produce the same result. gimp-edit-stroke when called from the PDB is supposed to use default values for the tool options, not the ones from the GUI. If you want to stroke using the tool options, use the stroke dialog.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/201.