GNOME Bugzilla – Bug 347423
double-click doesn't open half-shown items
Last modified: 2008-06-29 10:54:58 UTC
That bug has been opened on https://launchpad.net/distros/ubuntu/+source/nautilus/+bug/52606 "I don't know how to make myself clear, but when an item is not fully shown in a Nautilus window clicking on it shows it... but double-clicking doesn't open the file. I'll attach a couple screenshots to explain it graphically. http://librarian.launchpad.net/3342264/Pantallazo-tame.png screenshot http://librarian.launchpad.net/3342269/Pantallazo-tame-1.png screenshot2 ... > Thanks for your bug report. Which version of nautilus and Ubuntu do you use? In Edgy the "half shown" file is focussed and shown fully, when I double-click it - another double-click opens the file. Is that the issue you see yourself? ... I'm using Nautils 2.14.1 on Dapper. And yes, that's the behavior I'm getting too: If I click or double-click a "half-shown" file, it gets fully shown. Only then can I launch it by double-clicking again. I'm not sure if this behavior is a bug or a feature, but I at least find it rather annoying."
I think this bug is annoying for the user and can be easily hit, it's similar to bug 347633 in that it's also a mouse clicking usability bug, so the usability keyword could be added too. Also the product of this bug could be changed to "View as Icon" as the List view does not have this bug.
Do you guys thinkthis bug could be adressed anytime soon?
Bug 121111 could be somewhat related to the root of this bug.
*** Bug 373181 has been marked as a duplicate of this bug. ***
thanks Nelson
Created attachment 98463 [details] [review] Patch for Bug 347423 – double-click doesn't open half-shown items Hi, I've made a patch for this, the patch retards the reveal of the icon one second, so there's enough time for double clicking before the icon moves. This is what windows explorer does and seems the best solution.
Rejecting patch, delaying icon revealing by a fixed amount of time is really a crude hack. For instance, it will not fix the issue if the double-click delay is larger than the fixed time interval, and for people who want to reveal the icon, it will not reveal it immediately. The proper fix is to modify the handle_icon_button_press() handler: In the !details->icon_selected_on_button_down case, when calling select_one_unselect_others(), we would have to set a flag in the container that we revealed an icon. When we later handle the double click, we can modify the if (event->type == GDK_2BUTTON_PRESS) check in the same function [handle_icon_button_press()] to also do if (event->type == GDK_2BUTTON_PRESS || (flag && clicked_within_double_click_interval())) This check would have to work more or less like the "gtk-double-click-time" check in nautilus_icon_container_did_not_drag().
Created attachment 109605 [details] [review] Patch implementing cneumair guide to fix this bug :) Hi, this patch is working well for me, I also tested it under single-click-mode. The patch follows Christian's precise indications, and it works much better than my crude hack! :) Thanks Christian!
Oh,, and for bonus points, it seems my patch also fixes bug 430667 .. this is a lucky day!
When I try this patch it has some problems. When I double-click a directory in browser view, the directory is opened properly but the location bar is not updated, so when I press "Up" it goes up to the wrong directory.
Thanks for spotting this, I can see the bug, will try to fix it next week... O(In reply to comment #10) > When I try this patch it has some problems. When I double-click a directory in > browser view, the directory is opened properly but the location bar is not > updated, so when I press "Up" it goes up to the wrong directory. >
Created attachment 113455 [details] [review] Updated patch It's now fixed, the problem was that a gtk double click generates the following events: GDK_BUTTON_PRESS GDK_BUTTON_RELEASE GDK_BUTTON_PRESS GDK_2BUTTON_PRESS GDK_BUTTON_RELEASE so the icon was activated twice, one for the two button press that made it enter in the clicked_within_double_click_interval() part of the 'if clause' and one for the GDK_2BUTTON_PRESS part of the 'if clause'.. So I remove the GDK_2BUTTON_PRESS part of the 'if clause' because now it's redundant and now the icon is activated only once. I've checked it works well both in browser,spatial and single-click-mode..
Thanks for your efforts Nelson, that was indeed a typo in my instructions. Please commit the patch to trunk and to the GNOME 2.22 branch. I will look into the issue described by Jared in comment 10, the first version of this patch probably triggered another bug introduced with the GIO migration I have not been able to hunt down for some time, namely that sometimes the back/forward navigation is "stuck".
Just FYI, I just fixed the nasty bug in trunk and in the GNOME 2.22 branch, which was revealed due to double activation: http://svn.gnome.org/viewvc/nautilus?view=revision&revision=14288 http://svn.gnome.org/viewvc/nautilus?view=revision&revision=14287 It turns out that we did not properly cancel the pending location change when the old view was re-used for the new location.
(In reply to comment #13) > Thanks for your efforts Nelson, that was indeed a typo in my instructions. > Please commit the patch to trunk and to the GNOME 2.22 branch. Sorry, I don't have commit access, so please then commit them for me.
Thanks, committed - closing: http://svn.gnome.org/viewvc/nautilus?view=revision&revision=14296 http://svn.gnome.org/viewvc/nautilus?view=revision&revision=14297