After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 347408 - basesrc causes regressions in pull with 0 bytes
basesrc causes regressions in pull with 0 bytes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal blocker
: 0.10.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-07-13 14:51 UTC by Wim Taymans
Modified: 2006-07-13 15:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
restore previous behaviour (739 bytes, patch)
2006-07-13 14:53 UTC, Wim Taymans 		committed Details | Review

Description Wim Taymans 2006-07-13 14:51:07 UTC 
Please describe the problem:
basesrc <= 0.10.8 used to return GST_FLOW_UNEXPECTED when pulling 0 bytes. 0.10.8.2 returns _OK and a 0 bytes buffer if the offset is valid and UNEXPECTED when the offset is past the end of the file. Some plugins pull 0 bytes but then assert when they get a 0 sized buffer, they need fixing. 

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Wim Taymans 2006-07-13 14:53:29 UTC 
Created attachment 68872 [details] [review]
restore previous behaviour

suggested patch restores the previous behaviour for the next core release. When the plugins are fixed, this patch should be reverted again.
Comment 2 Tim-Philipp Müller 2006-07-13 14:58:57 UTC 
Can be confirmed by downloading this file:

  http://slomosnail.de/~slomo/temp/Anathema-Deep.mpc

and then doing

  gst-launch-0.10 filesrc location=Anathema-Deep.mpc ! decodebin ! fakesink

at the end it will g_assert (size > 0); in id3demux.


This doesn't happen with -good CVS, but is still a problem with the 0.10.3 release.
Comment 3 Jan Schmidt 2006-07-13 15:44:07 UTC 
Works here, please commit
Comment 4 Wim Taymans 2006-07-13 15:53:22 UTC 
        * libs/gst/base/gstbasesrc.c: (gst_base_src_update_length):
        * tests/check/elements/filesrc.c: (GST_START_TEST):
        Revert pull-0 fix for release. Disable check. Fixes #347408.