GNOME Bugzilla – Bug 347408
basesrc causes regressions in pull with 0 bytes
Last modified: 2006-07-13 15:53:34 UTC
Please describe the problem: basesrc <= 0.10.8 used to return GST_FLOW_UNEXPECTED when pulling 0 bytes. 0.10.8.2 returns _OK and a 0 bytes buffer if the offset is valid and UNEXPECTED when the offset is past the end of the file. Some plugins pull 0 bytes but then assert when they get a 0 sized buffer, they need fixing. Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
Created attachment 68872 [details] [review] restore previous behaviour suggested patch restores the previous behaviour for the next core release. When the plugins are fixed, this patch should be reverted again.
Can be confirmed by downloading this file: http://slomosnail.de/~slomo/temp/Anathema-Deep.mpc and then doing gst-launch-0.10 filesrc location=Anathema-Deep.mpc ! decodebin ! fakesink at the end it will g_assert (size > 0); in id3demux. This doesn't happen with -good CVS, but is still a problem with the 0.10.3 release.
Works here, please commit
* libs/gst/base/gstbasesrc.c: (gst_base_src_update_length): * tests/check/elements/filesrc.c: (GST_START_TEST): Revert pull-0 fix for release. Disable check. Fixes #347408.