After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 347182 - e-combo-button.c-CRITICAL **: e_combo_button_set_label: assertion `label != NULL' failed
e-combo-button.c-CRITICAL **: e_combo_button_set_label: assertion `label != N...
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Shell
2.8.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
: 348298 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-07-11 03:50 UTC by Hiroyuki Ikezoe
Modified: 2013-09-13 00:48 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
proposed patch (4.92 KB, patch)
2006-07-11 03:53 UTC, Hiroyuki Ikezoe 		accepted-commit_now Details | Review
revised patch (6.09 KB, patch)
2006-07-12 04:47 UTC, Hiroyuki Ikezoe 		committed Details | Review

Description Hiroyuki Ikezoe 2006-07-11 03:50:32 UTC 
Please describe the problem:
e-combo-button.c-CRITICAL **: e_combo_button_set_label: assertion `label != NULL' failed


Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Hiroyuki Ikezoe 2006-07-11 03:53:39 UTC 
Created attachment 68762 [details] [review]
proposed patch
Comment 2 Hiroyuki Ikezoe 2006-07-11 03:58:13 UTC 
               e_combo_button_set_label (E_COMBO_BUTTON (priv->new_button), NULL);

The above line is the problem, but I think new_button_change() and setup_toolbar_button have the same proccess, so the proccess should be written as a new function.
Comment 3 Hiroyuki Ikezoe 2006-07-11 04:02:23 UTC 
e_combo_button_set_label can accepts NULL, but call g_return_if_fail at begining of the function. This should be also fixed.

--- widgets/misc/e-combo-button.c       19 Jun 2006 10:00:18 -0000      1.24
+++ widgets/misc/e-combo-button.c       11 Jul 2006 03:58:35 -0000
@@ -567,7 +567,6 @@ e_combo_button_set_label (EComboButton *

        g_return_if_fail (combo_button != NULL);
        g_return_if_fail (E_IS_COMBO_BUTTON (combo_button));
-       g_return_if_fail (label != NULL);

        priv = combo_button->priv;
Comment 4 Karsten Bräckelmann 2006-07-12 02:19:33 UTC 
Cc'ing Srini.

Almost feels like we are sitting on the floor at GUADEC again... ;)
Comment 5 Srinivasa Ragavan 2006-07-12 03:39:41 UTC 
Hiroyuki: Your patch looks fine to commit. COmmit the removal of g_return_if_fail also with Changelog.
Comment 6 Hiroyuki Ikezoe 2006-07-12 04:47:14 UTC 
Created attachment 68791 [details] [review]
revised patch

Including ChangeLog for removal g_return_if_fail.
Comment 7 Hiroyuki Ikezoe 2006-07-12 04:58:21 UTC 
Can I commit this patch?
Comment 8 Srinivasa Ragavan 2006-07-12 05:00:14 UTC 
looks OK to commit.
Comment 9 Hiroyuki Ikezoe 2006-07-12 06:54:13 UTC 
Committed now.
Thanks!
Comment 10 Karsten Bräckelmann 2006-07-12 17:30:37 UTC 
Setting patch status according to comment 9.
Comment 11 André Klapper 2006-08-22 15:12:45 UTC 
*** Bug 348298 has been marked as a duplicate of this bug. ***