After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 347099 - Use of deprecated function dbus_connection_disconnect
Use of deprecated function dbus_connection_disconnect
Status: RESOLVED FIXED
Product: gnome-vfs
Classification: Deprecated
Component: Build
cvs (head)
Other All
: Normal normal
: ---
Assigned To: gnome-vfs maintainers
gnome-vfs maintainers
: 347222 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-07-10 14:42 UTC by Laurent Goujon
Modified: 2006-07-13 15:33 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
Quick patch (1.44 KB, patch)
2006-07-10 14:49 UTC, Laurent Goujon 		none Details | Review

Description Laurent Goujon 2006-07-10 14:42:32 UTC 
Please describe the problem:
See http://jhbuild.bxlug.be/builds/2006-07-10-0004/logs/gnome-vfs/#build

The function dbus_connection_disconnect was replaced by dbus_connection_close

Steps to reproduce:



Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Laurent Goujon 2006-07-10 14:49:36 UTC 
Created attachment 68718 [details] [review]
Quick patch

Patch to replace all dbus_connection_disconnect calls by dbus_connection_close
Comment 2 Elijah Newren 2006-07-11 20:04:08 UTC 
*** Bug 347222 has been marked as a duplicate of this bug. ***
Comment 3 Elijah Newren 2006-07-11 20:06:02 UTC 
Patch looks right to me (note that I'm not the maintainer, though), but diffs really should be made using the -up flags; otherwise the patch is usually nearly unreadable.
Comment 4 Christian Kellner 2006-07-12 22:15:05 UTC 
So this changed happend to dbus HEAD, right? It didn't land in any relase yet or am I mistaken here? If so then I would favour to wait until the next version dbus (including this change) is out or we have a promise that it will be before 2.15.4 happens. Otherwise distribution would have to patch gnome-vfs or ship a cvs/git version of dbus which seems not like an idea solution to me. 
The patch itself looks fine (despite the missing -up flags Elijah already pointed out)
Comment 5 Christian Kellner 2006-07-13 15:33:33 UTC 
Ok, I should have looked closer before writing that. the _close version is already there. I commit this patch. Thanks!