After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 346950 - network share bookmarks with spaces badly displayed in Places menu
network share bookmarks with spaces badly displayed in Places menu
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: menu
2.14.x
Other All
: Normal minor
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-07-07 22:08 UTC by Pav Lucistnik
Modified: 2006-07-23 14:40 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
crude patch modeled after what nautilus does with bookmarks (844 bytes, patch)
2006-07-07 22:09 UTC, Pav Lucistnik 		none Details | Review

Description Pav Lucistnik 2006-07-07 22:08:25 UTC 
Please describe the problem:
Gtk bookmarks of network shares containing hex escaped characters are not unescaped when displayed in gnome-panel's Places menu.

Steps to reproduce:
Put a line like this into ~/.gtk-bookmarks

smb://albator/DATA%20(D)

Actual results:
Places menu entry reads like DATA%20(D) on albator

Expected results:
Places menu entry should read like DATA (D) on albator

Does this happen every time?
Yes. Not fixed in 2.15.X either.

Other information:
Screenshots are at http://www.oook.cz/bsd/panelbug/ including comparision to Nautilus.
Comment 1 Pav Lucistnik 2006-07-07 22:09:54 UTC 
Created attachment 68602 [details] [review]
crude patch modeled after what nautilus does with bookmarks
Comment 2 Vincent Untz 2006-07-23 14:40:11 UTC 
Fixed, but I used gnome_vfs_format_uri_for_display() sooner.

2006-07-23  Vincent Untz  <vuntz@gnome.org>

	* panel-menu-items.c: (panel_place_menu_item_append_gtk_bookmarks):
	use gnome_vfs_unescape_string_for_display() instead of
	g_filename_display_basename() to make prettier strings.
	Fix bug #346950

Thanks!