GNOME Bugzilla – Bug 346243
Improve first-time secure page dialog text
Last modified: 2007-06-17 05:56:40 UTC
The first-time dialog when visiting a secure page mentions the pad lock icon in the status bar. It should be changed to reflect that the icon is now (also) in the location bar. Maybe mention the yellow background colour too.
Easy to fix; code is in embed/mozilla/GtkNSSSecurityWarningDialogs.cpp.
Created attachment 89384 [details] [review] Patch for bug 346243
Comment on attachment 89384 [details] [review] Patch for bug 346243 >Index: ChangeLog >=================================================================== >--- ChangeLog (revision 7067) >+++ ChangeLog (working copy) >@@ -1,3 +1,10 @@ >+2007-07-05 Jared Moore <cornflake.pirate@gmail.com> >+ >+ * embed/mozilla/GtkNSSSecurityWarningDialogs.cpp: >+ >+ Modified first-time dialog when visiting a secure page, to mention the >+ yellow location bar and padlock icon. Bug #346243. >+ > 2007-06-04 Christian Persch <chpe@gnome.org> > > * embed/ephy-embed.c: (ephy_embed_load_url): >Index: embed/mozilla/GtkNSSSecurityWarningDialogs.cpp >=================================================================== >--- embed/mozilla/GtkNSSSecurityWarningDialogs.cpp (revision 7067) >+++ embed/mozilla/GtkNSSSecurityWarningDialogs.cpp (working copy) >@@ -94,7 +94,9 @@ > GTK_RESPONSE_OK, > _("Security Notice"), > _("This page is loaded over a secure connection"), >- _("The padlock icon in the statusbar indicates whether a page is secure."), >+ _("For secure pages, the location bar is colored yellow and a padlock icon " >+ "is displayed.\n\nThe padlock icon in the statusbar also indicates " >+ "whether a page is secure."), > nsnull, _retval); > > *_retval = PR_TRUE;
Created attachment 89392 [details] [review] Patch for bug 346243 fixed Whoops, sorry about that - I'm a bit of a Bugzilla n00b. The first patch used spaces instead of tabs, that's fixed now.
Looks fine to me. Reinout?
I suggest: s/location bar/address entry/ (to be consistent with other messages) s/a padlock icon/a locked padlock icon/ (preferably with a visual example of the icon, not sure if that's possible) Furthermore, is the "security color" themeable? If yes, then we should probably say: s/is colored yellow/has a distinct color/ and the text should have the same background color as the secure color would be. Jared, could you adjust the text in the Epiphany online manual as well? ( http://svn.gnome.org/viewcvs/epiphany/trunk/help/C/epiphany.xml?view=markup under "identifying-secure-sites") Thanks!
clarification: by "the text" to have a background color I mean "distinct color".
Created attachment 89466 [details] [review] with suggested changes, but no colour or icon in message Yes, the address entry is themed - obviously I didn't check thoroughly enough there. Also changed the help text. I'm not sure whether the coloured text and icon is possible at the moment :/
I also removed some text in the help file that seemed to be incorrect.
Assuming it builds this time, ok to commit. Thanks for the patch :)
Ok. Committed to trunk, revision 7085. 2007-06-07 Diego Escalante Urrelo <diegoe@gnome.org> * embed/mozilla/GtkNSSSecurityWarningDialogs.cpp: * help/C/epiphany.xml: Modified first-time dialog when visiting a secure page, to mention the color and padlock icon in the address entry. Patch by Jared Moore. Fixes bug #346243.