After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 346192 - [PATCH] Pad blocking on events
[PATCH] Pad blocking on events
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.9
Assigned To: Edward Hervey
GStreamer Maintainers
: 346193 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-06-29 11:23 UTC by Edward Hervey
Modified: 2006-07-03 10:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for blocking on events (2.74 KB, patch)
2006-06-29 11:44 UTC, Edward Hervey 		none Details | Review
same thing with more comments (6.12 KB, patch)
2006-06-30 12:09 UTC, Wim Taymans 		none Details | Review
Patch with comments and test fix (7.35 KB, patch)
2006-07-01 11:24 UTC, Edward Hervey 		none Details | Review
Updated with smaller code (7.23 KB, patch)
2006-07-01 11:50 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2006-06-29 11:23:58 UTC 
Pads should properly block on events (see design document gstreamer/docs/design/part-block.txt).

This implements the proper pad behaviour for the design document.
Comment 1 Christian Kirbach 2006-06-29 11:27:41 UTC 
*** Bug 346193 has been marked as a duplicate of this bug. ***
Comment 2 Edward Hervey 2006-06-29 11:44:52 UTC 
Created attachment 68160 [details] [review]
Patch for blocking on events
Comment 3 Wim Taymans 2006-06-30 12:09:16 UTC 
Created attachment 68215 [details] [review]
same thing with more comments

Same patch but with more comments. The code in the event function still seems awkward (the switch checking for the event type and then the additional checking in the _IS_BLOCKED section)

Can you also attach the fix you had to do in the testsuite?
Comment 4 Edward Hervey 2006-07-01 11:24:28 UTC 
Created attachment 68237 [details] [review]
Patch with comments and test fix

Updated with gstevent test fix.
Comment 5 Edward Hervey 2006-07-01 11:50:04 UTC 
Created attachment 68238 [details] [review]
Updated with smaller code

Updated version. I combined the switch for flushing events with the pad block handling.
Comment 6 Edward Hervey 2006-07-03 10:31:46 UTC 
2006-07-03  Edward Hervey  <edward@fluendo.com>

	* gst/gstpad.c: (handle_pad_block), (gst_pad_push_event):
	Implement pad blocking on events according to part-block.txt.
	More comments on behaviour.
	* tests/check/gst/gstevent.c: (test_event):
	Send event to peer pad of blocked pad (else it will block).