After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 346097 - SIGSEGV when using --gst-plugin-load
SIGSEGV when using --gst-plugin-load
Status: VERIFIED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.x
Other All
: Normal critical
: 0.10.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-06-28 10:55 UTC by Peter Kjellerstedt
Modified: 2006-07-18 10:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix memory problems in gst.c (820 bytes, patch)
2006-06-28 10:56 UTC, Peter Kjellerstedt 		committed Details | Review

Description Peter Kjellerstedt 2006-06-28 10:55:08 UTC 
Steps to reproduce:
1. gst-inspect --load-with-plugin=whatever.so


Stack trace:
The crash is due to prepare_for_load_plugin_func() not using g_strdup() on its data before adding it to the preload_plugins list.  This then causes load_plugin_func() to use freed memory, and then freeing this memory a second time...

While looking at this I also noticed another case of duplicate memory freeing in split_and_iterate().

I have attached a patch which fixes both of these problems.


Other information:
Comment 1 Peter Kjellerstedt 2006-06-28 10:56:03 UTC 
Created attachment 68115 [details] [review]
Fix memory problems in gst.c
Comment 2 Tim-Philipp Müller 2006-06-28 15:18:58 UTC 
Committed, thanks for the patch!


 2006-06-28  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Peter Kjellerstedt <pkj at axis com>

        * gst/gst.c: (prepare_for_load_plugin_func), (split_and_iterate):
          Fix missing g_strdup() and double free when using the
          --gst-plugin-load command line option (#346097).