GNOME Bugzilla – Bug 345781
problem compiling with SunStudio compiler
Last modified: 2008-01-15 14:07:10 UTC
Attaching a patch that fixes compile problems on Solaris. Solaris header files requres defining __EXTENSIONS__ to get proper definitions etc. You get these errors with gimp.c and similar errors with main.c pkgbuild: "gimp.c", line 349: undefined symbol: SA_RESTART pkgbuild: "gimp.c", line 1335: undefined symbol: fd_set pkgbuild: "gimp.c", line 1335: syntax error before or at: readfds pkgbuild: "gimp.c", line 1337: incomplete struct/union/enum timeval: tv pkgbuild: "gimp.c", line 1342: improper member use: tv_sec pkgbuild: "gimp.c", line 1343: improper member use: tv_usec pkgbuild: "gimp.c", line 1349: warning: implicit function declaration: FD_ZERO pkgbuild: "gimp.c", line 1349: undefined symbol: readfds pkgbuild: "gimp.c", line 1350: warning: implicit function declaration: FD_SET pkgbuild: "gimp.c", line 1352: warning: implicit function declaration: select pkgbuild: "gimp.c", line 1352: undefined symbol: FD_SETSIZE pkgbuild: "gimp.c", line 1376: cannot recover from previous errors
Created attachment 67913 [details] [review] patch fixing Sun Studio compile problems Note if you want to make this Sun specific, you could add #ifdef __sun around the __EXTENSIONS__ definition, though it should be okay to define this for any platform. Also Sun Studio compiler seems to dislike the "return matrixmult_int" sntax in plug-ins/common/sel_gauss.c but changing the logic to put the return on a separate line seems to make it happy. Patch also includes this change.
Created attachment 67914 [details] [review] fix to previous patch Oops, updating patch so it applies properly. The previous attachment had some files at different patch -p levels.
Already fixed, in a different fashion. Please search for duplicates next time. *** This bug has been marked as a duplicate of 344203 ***