GNOME Bugzilla – Bug 345341
New IAccessibleAction methods
Last modified: 2006-08-02 17:52:26 UTC
Add the following IAccessibleAction methods to the appropriate adapters. Do not change the method signatures, but do feel free to change how they are implemented to make them work properly. setAccCaret() # move the caret to the location given by self.item_offset+self.char_offset # can use Text interface and setCaretOffset # should return False if self.item_offset is None or the result of setCaretOffset otherwise # should be added to default action adapter # raise NotImplementedError if Text not supported setAccText(text) # replace contents of text area with the given text # can use EditableText interface and setTextContents method # should return False if self.item_offset or the result of setTextContents otherwise # should be added to default action adapter # raise NotImplementedError if EditableText not supported insertAccText(text, attrs=None) # insert the text into the text area starting at self.item_offset+self.char_offset # attrs is an optional list of string name:value pairs indicating attributes to set on the text # can use EditableText interface and insertText or insertTextWithAttributes methods as appropriate to the given params # should return False if self.item_offset is None or the result of insertText* # should be added to default action adapter # raise NotImplementedError if EditableText not supported setAccTextAttrRun(por, attrs) # set the attrs list of string name:value pairs indicating attributes on the text from self.item_offset+self.char_offset up to por.item_offset+por.char_offset # can use EditableText interface and setAttributeRun method # should be added to default action adapter # should return False if self.item_offset or por.item_offset is None, or the result of setAttributeRun otherwise # raise ValueError if por.isSameAcc(self.accessible) is False # raise NotImplementedError if EditableText not supported copyAccText(por) # copy the text starting at self.item_offset+self.char_offset up to por.item_offset+por.char_offset # can use EditableText interface and copyText method # should be added to default action adapter # should return False if self.item_offset or por.item_offset is None, or the result of copyText otherwise # raise ValueError if por.isSameAcc(self.accessible) is False # raise NotImplementedError if EditableText not supported cutAccText(por) # cut the text starting at self.item_offset+self.char_offset up to por.item_offset+por.char_offset # can use EditableText interface and cutText method # should be added to default action adapter # should return False if self.item_offset or por.item_offset is None, or the result of cutText otherwise # raise ValueError if por.isSameAcc(self.accessible) is False # raise NotImplementedError if EditableText not supported deleteAccText(por) # delete the text starting at self.item_offset+self.char_offset up to por.item_offset+por.char_offset # can use EditableText interface and deleteText method # should be added to default action adapter # should return False if self.item_offset or por.item_offset is None, or the result of deleteText otherwise # raise ValueError if por.isSameAcc(self.accessible) is False # raise NotImplementedError if EditableText not supported pasteAccText(text) # paste the text at self.item_offset+self.char_offset # can use EditableText interface and pasteText method # should be added to default action adapter # should return False if self.item_offset is None, or the result of pasteText otherwise # raise NotImplementedError if EditableText not supported
I'm writing these routines in DefaultAction.py, but I don't know whether they require calling from somewhere parallel to Task/Tools/View.py (which provides scripting support for the routines I've added to Adapters/ATSPI/DefaultInfo.py/class DefaultAccInfoAdapter). Let me know if they need this (I don't know how to test without some way to call the routines from script or trap the output given some UI input. They probably require adding to LSRInterfaces.py for documentation purposes, as well, but I'm only guessing here--perhaps they aren't because they aren't scriptable (see above).
You should add the appropriate methods to Task/Tools/View.py. Also add dummy methods to LSRInterfaces.py as documentation.
Obviously I need to create another class in my testing Perk, EirikurPerk, but I don't know what it should be and what it should be a subclass of. I'm really unclear on this even after reading most of DefaultPerk.py and Task/Tools/View.py. The way the names accessible to Perks map to names in View.py map to names in De faultInfo.py or DefaultAction.py is just not obvious, partly because I'm not familiar with the terminology and partly because "who calls who" isn't clear to me. A hint would get the show on the road here and I can master the overview later, over time or from documents that I have probably neglected in my eagerness to be coding.
Look at section 7 of the GaimPerk tutorial on the LSR web site (http://live.gnome.org/LSR/ScriptDevelopers/GaimPerkTutorial). You want to define an InputTask subclass and define a hotkey for triggering it. The tutorial tells you how to do both.
Barring any major bugs, let's shoot for having this patch done by Friday, 7/7/06.
Late Friday afternoon. I will try for earlier, which is pretty likely.
Created attachment 68574 [details] [review] Never Mind. Defaultinfo.py: Removed unused includes in DefaultInfo.py Re-wrote getAccDefAttrs routine entirely to properly return a dict. Re-wrote getAccAttrs using the code I wrote for getAccDefTextAttrs. Now returns a dict. Code was tested in getAccDefTextAttrs(). Fixed epydoc to include input params in getAccText. LSRInterfaces.py: Fixed LSRInterfaces.py Removed inappropriate self input params, added epydoc for all input params. Task/Tools/View.py: Added epydoc for all input params, including POR. Re-wrote routines to remove refs to Interfaces.IText and use calls appropriate to this module.
Created attachment 68577 [details] Never mind. Just a simple text perk.
Comment on attachment 68574 [details] [review] Never Mind. Revised patch with fixes as per. Defaultinfo.py: Removed unused includes in DefaultInfo.py Re-wrote getAccDefAttrs routine entirely to properly return a dict. Re-wrote getAccAttrs using the code I wrote for getAccDefTextAttrs. Now returns a dict. Code was tested in getAccDefTextAttrs(). Fixed epydoc to include input params in getAccText. LSRInterfaces.py: Fixed LSRInterfaces.py Removed inappropriate self input params, added epydoc for all input params. Task/Tools/View.py: Added epydoc for all input params, including POR. Re-wrote routines to remove refs to Interfaces.IText and use calls appropriate to this module.
Added action methods to DefaultAction adapter. Still need Task/Tools/View methods.
Task/Tools/View methods in progress. I'm expecting to have something before morning, unless I can't adapt GAIMperk or something for the testing. In which case I will post the untested code for the record and get realtime help in the morning. The essential parts of GAIMperk seem to work with GAIM factored-out. Compile, anyway. Eirikur
Got imput-driven test perk working after stripping down the example to the barest bones. My earlier tries were too ambitious. My test perk now triggers a stackdump which says that my Task/Tools/View.py routines are calling my Adapters/ATSPI/DefaultAction.py routines with an extra added parameter that is coming from somewhere. We are bombing in PyLinAcc's __init__.py Here's an example of the call in View.py and the method declaration in DefaultAction.py, followed by the stack dumps from setAccCaret and setAccText. This has to be a simple problem. My IAccessibleInfo routines don't seem to have this problem in that they work fine from my test perk. View.py: return ai.setAccCaret() DefaultAction.py: @pyLinAcc.errorToLookupError def setAccCaret(): Mon, 10 Jul 2006 19:07:41 ERROR Tier Tier exception Traceback (most recent call last):
+ Trace 69265
rv = task.execute(layer=layer, **task_data)
print "setAccCaret:", self.setAccCaret()
return ai.setAccCaret()
return func(self, *args, **kwargs)
Mon, 10 Jul 2006 19:12:29 ERROR Tier Tier exception Traceback (most recent call last): File "/home/lsr/lsr/src/Tier.py", line 293, in _executeTask rv = task.execute(layer=layer, **task_data) File "/root/.lsr/ui/installed/perk/EirikurPerk.py", line 28, in execute print "setAccText:", self.setAccText("Msg. from Eirikur Hallgrimsson.") File "/home/lsr/lsr/src/Task/Tools/View.py", line 105, in setAccText return ai.setAccText(text) File "/home/lsr/lsr/src/pyLinAcc/__init__.py", line 119, in _inner return func(self, *args, **kwargs) TypeError: setAccText() takes exactly 1 argument (2 given) Help would be appreciated. It sort of looks like I have version skew or something. Eirikur
Fixed in the development version. The fix will be available in the next major release. Thank you for your bug report.