After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 345225 - [theoradec] Clipping for exact seeking
[theoradec] Clipping for exact seeking
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-06-18 10:24 UTC by Edward Hervey
Modified: 2006-06-19 09:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for clipping/dropping outoing buffers (2.25 KB, patch)
2006-06-18 10:27 UTC, Edward Hervey 		rejected Details | Review
change GST_DEBUG into GST_LOG (2.97 KB, patch)
2006-06-18 13:44 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2006-06-18 10:24:32 UTC 
Theoradec currently outputs buffers that are before segment start.

The following patches drop or clips accordingly the outgoing buffers. Only buffers within the newsegment start/stop values will be outputted.
Comment 1 Edward Hervey 2006-06-18 10:27:22 UTC 
Created attachment 67564 [details] [review]
patch for clipping/dropping outoing buffers
Comment 2 Tim-Philipp Müller 2006-06-18 12:11:38 UTC 
Please use LOG level for the debug output rather than DEBUG level here :)

Btw, wouldn't it make sense to put clip_buffer() into libgstvideo as a utility function (possibly as static inline into the header file so we don't need to actually link to it)?
Comment 3 Edward Hervey 2006-06-18 13:44:19 UTC 
Created attachment 67573 [details] [review]
change GST_DEBUG into GST_LOG
Comment 4 Edward Hervey 2006-06-19 09:58:20 UTC 
2006-06-19  Edward Hervey  <edward@fluendo.com>

	* ext/theora/theoradec.c: (clip_buffer), (theora_dec_push):
	Implement clipping for accurate seeking.
	Closes #345225