After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 344659 - Thunar Crash in gtk_tree_view
Thunar Crash in gtk_tree_view
Status: RESOLVED NOTABUG
Product: gtk+
Classification: Platform
Component: Widget: GtkTreeView
unspecified
Other All
: Normal normal
: ---
Assigned To: gtktreeview-bugs
gtktreeview-bugs
Depends on:
Blocks:
 
 
Reported: 2006-06-12 13:56 UTC by Nick Schermer
Modified: 2006-07-10 17:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Backtrace (14.75 KB, text/plain)
2006-06-12 13:57 UTC, Nick Schermer 		Details
overview of modifications needed (3.07 KB, text/plain)
2006-07-09 23:52 UTC, Kristian Rietveld 		Details

Description Nick Schermer 2006-06-12 13:56:31 UTC 
Please describe the problem:
When using the open location dialog, thunar crashed. You can find the Xfce bugreport (including bt) here:
http://bugzilla.xfce.org/show_bug.cgi?id=1891

gtk2 2.8.18
glib2 2.10.3


Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Nick Schermer 2006-06-12 13:57:07 UTC 
Created attachment 67184 [details]
Backtrace
Comment 2 Kristian Rietveld 2006-07-08 15:42:37 UTC 
I was only able to compile 0.3.0beta1 (the latest on the website ...) against gtk+ 2.10.x, and couldnt reproduce the crash.  Could you verify whether this issue is fixed by gtk+ 2.10.0?
Comment 3 Nick Schermer 2006-07-08 17:36:08 UTC 
Problem is still there with gtk 2.10.
Comment 4 Kristian Rietveld 2006-07-09 23:50:20 UTC 
I spend some more time installing a newer version of Thunar and the problem appeared (just the asserts, no segfaults here).

After a bunch of debugging it looks like the problem is caused by bugs in the implementation of ThunarListModel.  When the various signals (row-inserted, row-deleted) are emitted, the state of the model (the data structure + store->nrows) is not in sync with the information which has been given via the signals at that point.  For example row-inserted is emitted for the third inserted row, but nrows is already 10.

I'll attach a small diff with the changes I made to thunar-list-model.c to correct the implementation.  With this patch the problems disappear.  Please note that this is just an overview of the modifications I made; I am not planning to spend time turning this hack into a proper patch.
Comment 5 Kristian Rietveld 2006-07-09 23:52:18 UTC 
Created attachment 68691 [details]
overview of modifications needed
Comment 6 Kristian Rietveld 2006-07-09 23:53:05 UTC 
Not a problem in GTK+, closing as NOTABUG.
Comment 7 Nick Schermer 2006-07-10 17:15:21 UTC 
Benny suggested a slightly different patch, based on yours, and that solved the problem. Thanks for helping Kristian.