GNOME Bugzilla – Bug 344439
Esacpe in add contact window doesn't work
Last modified: 2006-06-19 20:10:11 UTC
Hitting escape in the add contact window doesn't have any effect.
The same goes for the History window.
For the add contact window, you can blame the GnomeDruid. I couldn't see a quick and easy wat to set the button (druid->cancel) to sync up with the GTK_RESPONSE_CANCEL for the dialog. If you know a way, do tell. For the history window, blame GTK for that, sicne it is a Close button not a Cancel button and it is not a dialog with a response either (it is a Window), I guess you would have to hook up the signal separately and I would rather the toolkit handle this. Unless it does and I haven't seen how.
Ah well, the history window looks like a dialog (with a button at the bottom), so I assumed it actuall WAS a dialog :)
Re. the history dialog: if it looks like a dialog, it should behave like one. What about removing the "Close" button at the bottom at all? It is of no use.
It doesn't matter if it looks like one, if it isn't one it won't behave like one, besides, how many dialogs do you know with a minimise and maximise button :P Removing the close then leave you open to the "Where is the 'Close' button" question that we would also have bug reports for. I personally would rather there was no close button, but people don't like that.
The Epiphany history window doesn't have a close button like dialogs have. This was a deliberate choice. The same goes for the bookmarks window in Epiphany.
I wouldn't mind removing the close button, and pointing people to epiphany as example. http://developer.gnome.org/projects/gup/hig/2.0/windows-dialog.html Reading that part, it's pretty clear to me that the history window is not a dialog so I think it would be OK to remove the close button.
Removed the close button, so this bug is no longer valid. Closing.
Now that the button is removed, the window border/padding should be decreased too (see Epiphany for an example how it looks).
Created attachment 67646 [details] [review] Proposed fix Remove the VBox and the HBox in the History window (who said this wasn't a dialog? ;-p) and decrease the notebook HBox child border.
Thanks, I've committed a variant of that patch. Please dont reuse bug reports for completely different things. It messes up the ChangeLog/NEWS if nothing else. I'm putting it back to INVALID since that's what the original bug report is now.