After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 343829 - gst_segment_copy is bogus
gst_segment_copy is bogus
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.5
Other Linux
: Normal normal
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-06-04 14:24 UTC by Paolo Borelli
Modified: 2006-06-05 12:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Paolo Borelli 2006-06-04 14:24:05 UTC 
static GstSegment *
gst_segment_copy (GstSegment * segment)
{
  GstSegment *result = NULL;

  if (segment) {
    result = gst_segment_new ();
    memcpy (result, segment, sizeof (GstSegment));
  }
  return NULL;
}


as you can see 'result' be actually returned after the memcpy
Comment 1 Edward Hervey 2006-06-05 12:56:52 UTC 
Nice spotting that ! Now fixed in CVS

2006-06-05  Edward Hervey  <edward@fluendo.com>

	* gst/gstsegment.c: (gst_segment_copy): 
	_copy() was always returning NULL...