After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 343796 - Italic Chinese character can't be show correctly in Win32.
Italic Chinese character can't be show correctly in Win32.
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: win32
1.12.x
Other All
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
pango-maint
Depends on:
Blocks:
 
 
Reported: 2006-06-04 03:58 UTC by huzheng
Modified: 2007-02-27 09:31 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
left: unknown glyph; right synthesized italic glyph (6.54 KB, image/png)
2006-06-05 18:37 UTC, Hans Breuer
Details

Description huzheng 2006-06-04 03:58:43 UTC
Please describe the problem:
<i>我</i>
When show this tag in a label or textview, it shows something strange.
Bold Chinese character have no problem.
Test environment: gtk-2.8.15, Windows XP.
In Linux, this have no problem.


Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Hans Breuer 2006-06-05 16:34:42 UTC
This beahviour is partially caused by bug #110521 - Pango not synthesizing italic variants on win32. I'll attach an updated patch there.
But the showing of "something strange" was also a bug. The hexbox (showing the hex code for unknown glyphs) was not properly sized. I've just commited a fix
to HEAD. Maybe it should also be applied to pango-1-12?

2006-06-05  Hans Breuer  <hans@breuer.org>

	* pango/pangocairo-win32font.c(compute_glyph_extents) : not only 
	handle PANGO_GLYPH_EMPTY but also PANGO_GLYPH_UNKNOWN_FLAG. 
	The latter is needed to have proper sizing of the "hex box" for 
	missing glyphs. It also stops cairo complaining about unknown glyphs.
	Fixes part of bug #343796.
	
Comment 2 Tor Lillqvist 2006-06-05 18:05:17 UTC
Yes, please do apply to pango-1-12, too. Thanks!
Comment 3 Hans Breuer 2006-06-05 18:37:05 UTC
Created attachment 66788 [details]
left: unknown glyph; right synthesized italic glyph

applied to pango-1-12. Now this is kind of a duplicate of bug #110521.
Still leaving this one open cause the other bug sounds like a theoretical 
enhancement. But this one shows real buggy behaviour.
BTW: the attached PNG is a composed before/after. In Dia you can just
select e.g. 'sans' and 'italic' for a text. And the italic did break
the rendering; but allowed me to see the other bug ;)
Comment 4 Hans Breuer 2006-06-05 18:39:04 UTC
Reassigning to Pango, where it needs to be fixed.
Comment 5 Hans Breuer 2006-06-05 21:07:53 UTC
Applied to HEAD and pango-1-12:

2006-06-05  Hans Breuer  <hans@breuer.org>

	* pango/pangowin32-fontmap.c(pango_win32_font_map_init) : synthesize
	some italic variants for fonts no having them already. This fixes
	bug #343796 and for the italic case also bug #110521.
Comment 6 Tor Lillqvist 2007-02-13 02:25:08 UTC
Reopening as the patch committed as a fix to bug #110521 seems to be somewhat broken.
Comment 7 Tor Lillqvist 2007-02-27 09:31:39 UTC
Should be fixed now.