After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 343538 - GstCollectPads doesn't reset EOS fields when stopped
GstCollectPads doesn't reset EOS fields when stopped
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.7
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-31 21:08 UTC by Alessandro Decina
Modified: 2006-06-01 09:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Testcase and fix (6.04 KB, patch)
2006-05-31 21:08 UTC, Alessandro Decina 		committed Details | Review

Description Alessandro Decina 2006-05-31 21:08:11 UTC 
GstCollectPads doesn't reset pads->eospads when is stopped. That may result in wrong behaviour if the same instance is started again without removing and readding the pads.
Comment 1 Alessandro Decina 2006-05-31 21:08:54 UTC 
Created attachment 66557 [details] [review]
Testcase and fix
Comment 2 Wim Taymans 2006-06-01 09:02:52 UTC 
Thanks for the patch!


        Patch by: Alessandro Decina <alessandro at nnva dot org>

        * libs/gst/base/gstcollectpads.c: (gst_collect_pads_stop):
        Make sure the EOS flag is cleared from pads after a flush
        or stop. Fixes #343538.

        * tests/check/libs/collectpads.c: (GST_START_TEST),
        (gst_collect_pads_suite):
        Added test for collectpads reusage after EOS.