After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 342835 - [Patch] More natural sorting of playlists by artist
[Patch] More natural sorting of playlists by artist
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: User Interface
git master
Other All
: Normal minor
: 2.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-24 19:13 UTC by Denis Washington
Modified: 2006-07-02 19:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for more natural by-artist sorting (1.89 KB, patch)
2006-05-24 19:15 UTC, Denis Washington 		committed Details | Review

Description Denis Washington 2006-05-24 19:13:59 UTC 
I noticed that if you sort playlists by artist, the songs of one album are not
kept together, but get intermixed. This patch should change this. It may need
testing, but hasn't made problems with my banshee so far (and I use with a few
hours a day).

Other information:
Comment 1 Denis Washington 2006-05-24 19:15:38 UTC 
Created attachment 66146 [details] [review]
Patch for more natural by-artist sorting

I also removed one two spaces that shouldn't be there according to HACKING.
Comment 2 Denis Washington 2006-05-27 17:02:38 UTC 
Changelog:

2006-05-24  Denis Washington  <dwashington@gmx.net>

  * src/PlaylistView.cs: If sorting by artist, secondarily sort by album so
  tracks from different albums of one artist don't get mixed up.
Comment 3 Øivind Hoel 2006-05-27 20:36:46 UTC 
I can confirm the original behaviour, and the supplied patch seems to make sure albums are sorted properly within artists while sorting by the latter. The only thing this misses is also sorting by track n# within albums :)
Comment 4 Denis Washington 2006-05-28 13:08:13 UTC 
Looking at the code, this is already done in 0.11.0 cvs.
Comment 5 Patrick van Staveren 2006-05-31 18:09:38 UTC 
Can we confirm that this bug can be closed since it's fixed in cvs?  If so, I'll close the bug.
Comment 6 Denis Washington 2006-06-01 17:39:29 UTC 
No, i meant the secondary by-track sorting when sorting by album is fixed in cvs (replying to comment #3), but the sorting-by-artist problem still remains without the patch submitted here.
Comment 7 Aaron Bockover 2006-07-02 19:33:58 UTC 
Applied in CVS. Thanks!