GNOME Bugzilla – Bug 342640
crash playing from itunes
Last modified: 2006-05-29 21:25:15 UTC
1. Connect to RB share from iTunes on XP 2. Enter password 3. Double click on track to play Backtrace was generated from '/opt/gnome/bin/rhythmbox' Using host libthread_db library "/lib/libthread_db.so.1". `shared object read from target memory' has disappeared; keeping its symbols. [Thread debugging using libthread_db enabled] [New Thread -1208396080 (LWP 14074)] [New Thread 55716768 (LWP 14089)] [New Thread 38288288 (LWP 14077)] 0x00abe402 in __kernel_vsyscall ()
+ Trace 68381
Thread 1 (Thread -1208396080 (LWP 14074))
I get the same crash when playing from a RB 0.9.4.1 client too. Maybe a libsoup bug.
Related to bug #334469. Hitting the g_return_if_fail introduced by: http://cvs.gnome.org/viewcvs/libsoup/libsoup/soup-message-io.c?r1=1.25&r2=1.26 There is a comment in soup-socket.c:soup_socket_disconnect(): /* Give all readers a chance to notice the connection close */ g_signal_emit (sock, signals[READABLE], 0); soup-message-io.c:io_read() is connected to the readable signal. So SOUP_MESSAGE_IO_STATE_DONE should indicate to io_read a disconnect notice.
Created attachment 66141 [details] [review] patch I don't know how io_read should react to this notice but this stops the crash.
Just removing the g_return_if_fail also fixes the crash.
sure, it's only crashing because you're running with g_fatal_criticals or whatever it's called. :)
Right, but it probably shouldn't be a g_return_if_fail if the condition is allowed.
Created attachment 66143 [details] [review] counter patch It's not allowed. That's why there's a return_if_fail! :) Does this patch work for you?
Touché! :) Yes this seems to work fine. Thank you.
Excellent. Thank you for tracking down the source of the bug. I've pinged the reporter of 334469 and another person who reported suddenly seeing lots of instances of the new warning, to see if this fixes it for them as well. Even if I don't hear back from them, I'll put out a new release with this fix for GNOME 2.14.2 on May 31.
Created attachment 66305 [details] [review] 3rd patch And here is yet another version of the patch... If at all possible, could you please test that this works this weekend so it will have gotten a little bit of testing before Monday?
fixed in cvs, and in libsoup 2.2.93
Oops. Sorry I didn't get a chance to try this out this weekend. Ironically, I was busy repairing carpenter ant damage in my porch. Thanks Dan.