After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 342382 - Memory leaks in e-name-selector-entry.c
Memory leaks in e-name-selector-entry.c
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
1.8.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2006-05-20 03:35 UTC by Hiroyuki Ikezoe
Modified: 2013-09-14 16:49 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
patch (1.57 KB, patch)
2006-05-20 03:37 UTC, Hiroyuki Ikezoe 		needs-work Details | Review
revised patch (1.56 KB, patch)
2006-05-20 10:45 UTC, Hiroyuki Ikezoe 		committed Details | Review

Description Hiroyuki Ikezoe 2006-05-20 03:35:07 UTC 
Please describe the problem:
Memory leaks in e-name-selector-entry.c

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Hiroyuki Ikezoe 2006-05-20 03:37:14 UTC 
Created attachment 65872 [details] [review]
patch
Comment 2 Veerapuram Varadhan 2006-05-20 10:09:05 UTC 
+	ENameSelectorEntry *name_selector_entry = E_NAME_SELECTOR_ENTRY (object);
+
+	if (!name_selector_entry->entry_completion) {

Did you verify your fix?  I guess, you mean...

+	ENameSelectorEntry *name_selector_entry = E_NAME_SELECTOR_ENTRY (object);
+
+	if (name_selector_entry->entry_completion) {

Correct me, if I am wrong.
Comment 3 Hiroyuki Ikezoe 2006-05-20 10:45:04 UTC 
Created attachment 65887 [details] [review]
revised patch

Ooops. My mistake. I'm quite silly.
Comment 4 Harish Krishnaswamy 2006-06-07 08:49:03 UTC 
Approved for commit.
Comment 5 André Klapper 2006-06-09 02:56:24 UTC 
patch committed both to stable branch and HEAD:
http://cvs.gnome.org/viewcvs/evolution-data-server/libedataserverui/e-name-selector-entry.c?r1=1.31&r2=1.32
http://cvs.gnome.org/viewcvs/evolution-data-server/libedataserverui/e-name-selector-entry.c?r1=1.30&r2=1.30.2.1

fix will be included in stable evolution 2.6.3 and unstable evolution 2.7.3.
thanks a lot!