After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 342174 - Avoid NOOP in zoom_region_set_viewport
Avoid NOOP in zoom_region_set_viewport
Status: RESOLVED FIXED
Product: gnome-mag
Classification: Deprecated
Component: magnifier-utility
0.12.x
Other All
: Low enhancement
: ---
Assigned To: bill.haneman
bill.haneman
Depends on:
Blocks:
 
 
Reported: 2006-05-17 20:28 UTC by Carlos Eduardo Rodrigues Diógenes
Modified: 2006-11-27 21:59 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
patch the issue (1.09 KB, patch)
2006-11-27 18:04 UTC, Carlos Eduardo Rodrigues Diógenes 		accepted-commit_now Details | Review

Description Carlos Eduardo Rodrigues Diógenes 2006-05-17 20:28:13 UTC 
We could return if the viewport passed is equal to actual viewport. Calls that try to set viewport with the same value already configured is something that the client must avoid, but some times can occur and we can avoid a lot of NOOP.
Comment 1 bill.haneman 2006-07-27 13:21:26 UTC 
I don't think this is a very important noop check, because existing clients call setViewport very infrequently.
Comment 2 Carlos Eduardo Rodrigues Diógenes 2006-11-27 18:04:09 UTC 
Created attachment 77235 [details] [review]
patch the issue

since the patch is straightforward here it is anyway.
Comment 3 Carlos Eduardo Rodrigues Diógenes 2006-11-27 21:59:49 UTC 
Fixed in the development version. The fix will be available in the next major release. Thank you for your bug report.