After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 342076 - Don't highlight find results when "Loading" text is showed
Don't highlight find results when "Loading" text is showed
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other All
: Normal minor
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-17 04:08 UTC by Ricardo Markiewicz
Modified: 2006-05-27 09:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshots that show the bug (39.53 KB, image/png)
2006-05-17 04:08 UTC, Ricardo Markiewicz 		  Details
Don't show highlight rects if page can't be showed (2.09 KB, patch)
2006-05-17 04:12 UTC, Ricardo Markiewicz 		committed Details | Review

Description Ricardo Markiewicz 2006-05-17 04:08:09 UTC 
Please describe the problem:
When you are finding and the "Loading" text is displayed, the highlight results
rects are always show.

Steps to reproduce:
1. 
2. 
3. 

Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Ricardo Markiewicz 2006-05-17 04:08:52 UTC 
Created attachment 65632 [details]
Screenshots that show the bug
Comment 2 Ricardo Markiewicz 2006-05-17 04:12:19 UTC 
Created attachment 65633 [details] [review]
Don't show highlight rects if page can't be showed

2006-05-17  Ricardo Markiewicz  <rmarkie@fi.uba.ar>

  * shell/ev-view.c: (draw_one_page), (ev_view_expose_event):

  Don't show highlight rects if page can't be showed.
  Fix for the bug #342076.
Comment 3 Nickolay V. Shmyrev 2006-05-17 17:11:04 UTC 
Thanks, nice catch. Please commit but with minor change - first check for EV_IS_DOCUMENT_FIND, then check for page loading.
Comment 4 Ricardo Markiewicz 2006-05-17 18:24:28 UTC 
If I check first for EV_IS_DOCUMENT_FIND, and return FALSE, I never call draw_one_page and the page Pixbuf or "Loading" text will never displayed.

I don't understand what you says.
Comment 5 Nickolay V. Shmyrev 2006-05-27 09:39:12 UTC 
That was my fault. Thanks a lot Ricardo, the patch was committed.