After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 341932 - Small buffer in for rendering strings in mail/em-format-html.c
Small buffer in for rendering strings in mail/em-format-html.c
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.2.x (obsolete)
Other All
: Normal critical
: ---
Assigned To: Srinivasa Ragavan
Evolution QA team
Depends on:
Blocks: Persian
 
 
Reported: 2006-05-16 03:13 UTC by Roozbeh Pournader
Modified: 2013-09-10 14:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to enlarge the buffer to 256 characters, which should be much more than enough (600 bytes, patch)
2006-05-16 03:14 UTC, Roozbeh Pournader 		committed Details | Review
screenshot showing the leak in Persian before the fix (by Hooman Mesgary) (74.95 KB, image/png)
2006-05-16 04:28 UTC, Roozbeh Pournader 		  Details

Description Roozbeh Pournader 2006-05-16 03:13:29 UTC 
A buffer in mail/em-format-html.c which is used for rendering translations of the string "<I> (%a, %R %Z)</I>" is not large enough to handle some of the translations (including Persian). This results in the output string not ending in '\0', resulting in weird things appearing on the screen and possibly crashes.

The bug still exists in HEAD. Will attach a patch.

FarsiWeb's internal reference:
farsiweb #335, evolution-small-date-buffer.patch, reported by Hooman Mesgary, patch by Roozbeh Pournader
Comment 1 Roozbeh Pournader 2006-05-16 03:14:45 UTC 
Created attachment 65568 [details] [review]
patch to enlarge the buffer to 256 characters, which should be much more than enough
Comment 2 Roozbeh Pournader 2006-05-16 04:28:35 UTC 
Created attachment 65569 [details]
screenshot showing the leak in Persian before the fix (by Hooman Mesgary)
Comment 3 André Klapper 2006-08-29 13:41:57 UTC 
roozbeh, can you add a cvs head changelog entry diff for that patch? i'd like to get this in for 2.8.
Comment 4 ushveen kaur 2006-09-26 10:47:41 UTC 
adding srini to cc
Comment 5 Srinivasa Ragavan 2006-09-27 04:11:13 UTC 
Please commit with a changelog.
Comment 6 Srinivasa Ragavan 2006-09-29 11:32:41 UTC 
Fixed to head.