After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 341845 - [gail-gnome] fix compile warnings
[gail-gnome] fix compile warnings
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: gail
unspecified
Other Linux
: Normal normal
: ---
Assigned To: bill.haneman
bill.haneman
Depends on:
Blocks:
 
 
Reported: 2006-05-15 12:03 UTC by Christian Persch
Modified: 2006-09-25 16:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (9.81 KB, patch)
2006-05-15 12:07 UTC, Christian Persch 		committed Details | Review

Description Christian Persch 2006-05-15 12:03:23 UTC 
Gail-GNOME has some compile warnings with mismatched/undefined prototypes. AIUI, those can lead to miscompilation on 64bit systems.

Attached patch makes gail-gnome -Werror clean.
Comment 1 Christian Persch 2006-05-15 12:07:18 UTC 
Created attachment 65492 [details] [review]
patch
Comment 2 bill.haneman 2006-09-25 15:50:46 UTC 
Comment on attachment 65492 [details] [review]
patch

What's up with the G_UNLIKELYs ?
Comment 3 Christian Persch 2006-09-25 16:49:11 UTC 
They annotate the expression for branch prediction. Since the condition will only be true once, it makes the subsequent calls predict the right branch (that's faster on some CPU architectures). The stock gobject G_DEFINE_TYPE* macros use this as well, so I think it's safe.