After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 341595 - Dialog displayed when opening a broken link should cancel by default
Dialog displayed when opening a broken link should cancel by default
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File and Folder Operations
2.23.x
Other Linux
: Normal normal
: 2.24.x
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-12 23:06 UTC by Sven Arvidsson
Modified: 2010-05-02 22:52 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
Proposed patch with GtkMessageDialog (1.57 KB, patch)
2008-06-23 19:12 UTC, Sven Salzwedel 		reviewed Details | Review

Description Sven Arvidsson 2006-05-12 23:06:33 UTC 
This was reported to the Debian BTS.
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=337335

When opening a broken symlink, nautilus asks what to do and wants to
delete the link by default. This is especially annoying when working in
a network environment without mounting the proper shared directories. I
often simply forget to mount the shares and delete links by accident.

Please change the default dialog choice to cancel. No system should
delete anything by default.
Comment 1 Sven Salzwedel 2008-06-23 19:11:45 UTC 
For some reasons setting the response type at the relevant position on the eel dialog has no effect. So I've created a patch which uses a GtkMessageDialog (it looks the same).
Comment 2 Sven Salzwedel 2008-06-23 19:12:43 UTC 
Created attachment 113285 [details] [review]
Proposed patch with GtkMessageDialog
Comment 3 A. Walton 2009-01-05 07:19:46 UTC 
Not sure exactly why this isn't a one-liner:

-gtk_dialog_set_default_response (dialog, GTK_RESPONSE_YES);
+gtk_dialog_set_default_response (dialog, GTK_RESPONSE_CANCEL);

But before this change goes in we should probably review the other cases so that we're not making this case inconsistent with the rest.
Comment 4 Sven Salzwedel 2009-01-05 08:14:27 UTC 
For some reason GTK_RESPONSE_CANCEL didn't work at the time I wrote the patch. So instead of "fixing" eel, I used GtkMessageDialog. Did you try the one-liner actually?
Comment 5 A. Walton 2009-01-05 08:25:42 UTC 
No I haven't, just agreeing with you that it is bizarre.
Comment 6 Cosimo Cecchi 2010-05-02 22:52:49 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.