After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 341451 - port to gtkstatusicon
port to gtkstatusicon
Status: RESOLVED FIXED
Product: zenity
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Zenity Maintainers
Zenity Maintainers
Depends on: 341450
Blocks:
 
 
Reported: 2006-05-11 18:42 UTC by Christian Persch
Modified: 2006-07-28 21:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
first cut (31.95 KB, patch)
2006-05-11 18:44 UTC, Christian Persch 		needs-work Details | Review
updated patch (17.68 KB, patch)
2006-05-25 19:22 UTC, Christian Persch 		none Details | Review

Description Christian Persch 2006-05-11 18:42:41 UTC 
Zenity should use gtkstatusicon (from gtk 2.9) instead of eggtrayicon. I'm going to attach a partial path; but I've discovered a problem with using gtkstatusicon+libnotify.
Comment 1 Christian Persch 2006-05-11 18:44:15 UTC 
Created attachment 65267 [details] [review]
first cut
Comment 2 Christian Persch 2006-05-25 19:22:03 UTC 
Created attachment 66217 [details] [review]
updated patch

This patch fixes notifications with libnotify, but depends on an API addition in libnotify, see http://trac.galago-project.org/ticket/60 .
Comment 3 Vincent Untz 2006-07-25 13:55:45 UTC 
Would be nice to have for 2.16.
Comment 4 Christian Persch 2006-07-25 18:59:27 UTC 
The libnotify API addition is now available in a release, the requirement is version >= 0.4.1.
Comment 5 Lucas Rocha 2006-07-28 21:25:15 UTC 
Applied in HEAD. Thanks!

2006-07-27  Lucas Rocha  <lucasr@gnome.org>

        * src/notification.c (-set_scaled_pixbuf,
        +zenity_notification_icon_update,
        -zenity_notification_icon_press_callback,
        +zenity_notification_icon_size_changed_cb,
        -zenity_notification_icon_expose_callback,
        -zenity_notification_icon_destroy_callback,
        +zenity_notification_icon_activate_cb,
        zenity_notification_handle_stdin, zenity_notification),
        src/util.[ch] (+zenity_util_stock_from_filename,
        zenity_util_pixbuf_new_from_file), Makefile.am, configure.in:

        Migration to gtk_status_icon (Fixes bug #341451). Patch from
        Christian Persch <chpe@gnome.org>.

        * src/eggtrayicon.[ch]: removed.