After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 341446 - computer:/// should display all drives, not only user-visible ones
computer:/// should display all drives, not only user-visible ones
Status: RESOLVED WONTFIX
Product: gnome-vfs
Classification: Deprecated
Component: Module: (other)
2.14.x
Other Linux
: High normal
: 2.14
Assigned To: gnome-vfs maintainers
gnome-vfs maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-11 18:26 UTC by Xavier Claessens
Modified: 2008-09-06 19:10 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
proposed patch (1.62 KB, patch)
2006-05-11 19:23 UTC, Xavier Claessens
none Details | Review
better patch (4.84 KB, patch)
2006-05-19 19:55 UTC, Xavier Claessens
none Details | Review
another proposed patch (2.26 KB, patch)
2006-05-24 19:39 UTC, Xavier Claessens
none Details | Review

Description Xavier Claessens 2006-05-11 18:26:04 UTC
Now that gnomeVFS has been patched to say that CDROM (and other auto-mounted) drives are not user-visible, I think that computer:/// shoud display all drives/volumes and not only user-visible.
Comment 1 Xavier Claessens 2006-05-11 19:23:22 UTC
Created attachment 65268 [details] [review]
proposed patch

I haven't tested the patch because I'm not on my development machine, but it is simple enough to hope I made no error :-)
Comment 2 Christian Kellner 2006-05-14 10:08:19 UTC
2006-05-14  Christian Kellner  <gicmo@gnome.org>
	
	Backported patch by Alexander Larrson from HEAD to unbreak
	Christian's Unalias MIME types patch (Fixes bug #341446):

	* libgnomevfs/gnome-vfs-mime-info-cache.c: (get_all_parent_types):
	Lock around calls to xdg_mime_*
Comment 3 Christian Kellner 2006-05-14 10:10:18 UTC
Wrong bug, stupid me! Sorry for the spam!
Comment 4 Alexander Larsson 2006-05-16 10:47:10 UTC
Commited on HEAD and gnome-2-14.
Comment 5 Xavier Claessens 2006-05-19 18:41:13 UTC
I've tested the patch and it doesn't do exactly what it should. Now I get all volumes like /home, /, etc. I'm preparing a better patch.
Comment 6 Xavier Claessens 2006-05-19 19:55:30 UTC
Created attachment 65858 [details] [review]
better patch

I think it's better like that.
Comment 7 Sebastien Bacher 2006-05-22 14:40:19 UTC
Could you send the patch on the list for comment? I would prefer to get it commited to CVS before modifying the dapper package
Comment 8 Xavier Claessens 2006-05-24 19:39:49 UTC
Created attachment 66148 [details] [review]
another proposed patch

See discution on the mailing-list:
http://mail.gnome.org/archives/gnome-vfs-list/2006-May/msg00021.html
Comment 9 Alexander Larsson 2006-05-30 10:05:56 UTC
I'm commiting the last patch with some more comment in it to gnome-2-14 so that i can release a working 2.14.2. But really, the real bug is in the hal volume manager backend (as discussed on the list), it shouldn't create drive objects for these mountpoints at all.

We need to get a real fix into 2.15.x
Comment 10 Xavier Claessens 2006-07-12 08:23:20 UTC
Ok so what do we do now for 2.15 ? I see 2 tings:

1) Should HAL backend create drive objects ? Not everybody seems agree...
2) What should we do with drive which have more than one volume when mounted ?

At least if we can't find a good solution in time for 2.15 we should commit the patch commited in 2.14.
Comment 11 André Klapper 2008-09-06 19:10:52 UTC
gnome-vfs has been deprecated and superseded by gio/gvfs since GNOME 2.22, hence mass-closing many of the gnome-vfs requests/bug reports. This means that gnome-vfs is NOT actively maintained anymore, however patches are still welcome.

If your reported issue is still valid for gio/gvfs, please feel free to file a bug report against glib/gio or gvfs.

@Bugzilla mail recipients: query for gnome-vfs-mass-close to get rid of these notification emails all together.


General further information: http://en.wikipedia.org/wiki/GVFS 
Reasons behind this decision are listed at http://www.mail-archive.com/gnome-vfs-list@gnome.org/msg00899.html