GNOME Bugzilla – Bug 341446
computer:/// should display all drives, not only user-visible ones
Last modified: 2008-09-06 19:10:52 UTC
Now that gnomeVFS has been patched to say that CDROM (and other auto-mounted) drives are not user-visible, I think that computer:/// shoud display all drives/volumes and not only user-visible.
Created attachment 65268 [details] [review] proposed patch I haven't tested the patch because I'm not on my development machine, but it is simple enough to hope I made no error :-)
2006-05-14 Christian Kellner <gicmo@gnome.org> Backported patch by Alexander Larrson from HEAD to unbreak Christian's Unalias MIME types patch (Fixes bug #341446): * libgnomevfs/gnome-vfs-mime-info-cache.c: (get_all_parent_types): Lock around calls to xdg_mime_*
Wrong bug, stupid me! Sorry for the spam!
Commited on HEAD and gnome-2-14.
I've tested the patch and it doesn't do exactly what it should. Now I get all volumes like /home, /, etc. I'm preparing a better patch.
Created attachment 65858 [details] [review] better patch I think it's better like that.
Could you send the patch on the list for comment? I would prefer to get it commited to CVS before modifying the dapper package
Created attachment 66148 [details] [review] another proposed patch See discution on the mailing-list: http://mail.gnome.org/archives/gnome-vfs-list/2006-May/msg00021.html
I'm commiting the last patch with some more comment in it to gnome-2-14 so that i can release a working 2.14.2. But really, the real bug is in the hal volume manager backend (as discussed on the list), it shouldn't create drive objects for these mountpoints at all. We need to get a real fix into 2.15.x
Ok so what do we do now for 2.15 ? I see 2 tings: 1) Should HAL backend create drive objects ? Not everybody seems agree... 2) What should we do with drive which have more than one volume when mounted ? At least if we can't find a good solution in time for 2.15 we should commit the patch commited in 2.14.
gnome-vfs has been deprecated and superseded by gio/gvfs since GNOME 2.22, hence mass-closing many of the gnome-vfs requests/bug reports. This means that gnome-vfs is NOT actively maintained anymore, however patches are still welcome. If your reported issue is still valid for gio/gvfs, please feel free to file a bug report against glib/gio or gvfs. @Bugzilla mail recipients: query for gnome-vfs-mass-close to get rid of these notification emails all together. General further information: http://en.wikipedia.org/wiki/GVFS Reasons behind this decision are listed at http://www.mail-archive.com/gnome-vfs-list@gnome.org/msg00899.html