GNOME Bugzilla – Bug 341070
[PATCH] About dialog should follow GnomeGoals guidelines.
Last modified: 2008-12-07 15:08:14 UTC
As in http://live.gnome.org/GnomeGoals/AboutDialog , the about dialog is remade. I don't know if you like this. If not, please close this bug as invalid but if you like it, you should renew the web (if you wanna use it) and/or the license :)
Created attachment 65045 [details] [review] About dialog remade Hope you like it :)
It has a bug, I didn't noticed before. The string always should be "translator-credits" and not "translator_credits" ('-' instead '_'). It seems that <a href="http://bugzilla.gnome.org/show_bug.cgi?id=300962">#300962</a> was partially fixed. It can be applied fixing that bug :-) Anyway, I'll open a new bug for the 'gnome-network' part.
Nevermind. translator-credits it is fine. I confused myself. But, what does "GPL2+" means? Currently gnome-nettool is licensed using GPL2.
The URL looks ugly because there is no link at all. We need to get #337358 fixed before to apply this patch. Also, we need #336225 fixed to have the license working fine.
Please also note that http://live.gnome.org/GnomeGoals/AboutDialog is only a proposal and not a GnomeGoal at this time. http://live.gnome.org/GnomeGoals says: /!\ Warning: These are just ideas, and not approved for project-wide application. Even when drafted, they should not be applied before they are officially turned into a GNOME Goal.
Ok, so waiting for those 2 bugs to be resolved and later we'll revisit this one.
Bug 337358 has been fixed now, so it's down to the last gtk+ issue.
Created attachment 124099 [details] [review] Updated patch with artists credits
I applied the patch I attached. I added credits for artist and I omitted the URL ('website'). Thanks for the report. It's fixed in head.