After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 340622 - Clock applet crashes when double-clicking a date while evolution startup fails
Clock applet crashes when double-clicking a date while evolution startup fails
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: clock
2.14.x
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
: 353809 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-05-04 12:30 UTC by Jan de Groot
Modified: 2007-01-06 09:22 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
Checks GError pointer before usage (883 bytes, patch)
2006-05-04 12:32 UTC, Jan de Groot 		none Details | Review
Proposed patch (724 bytes, patch)
2006-09-04 06:58 UTC, Vincent Untz 		committed Details | Review

Description Jan de Groot 2006-05-04 12:30:13 UTC 
The clock applet hangs when double-clicking a date and something in the invocation of evolution fails. When closing the clock applet and opening it again, the applet crashes. This is due to the usage of a GError pointer that is not checked before use.

A patch for this will get attached.
Comment 1 Jan de Groot 2006-05-04 12:32:04 UTC 
Created attachment 64804 [details] [review]
Checks GError pointer before usage
Comment 2 Vincent Untz 2006-05-29 20:40:40 UTC 
I don't think this is the correct fix. If the call fails, the error should be set (according to the doc).

I'm not sure it's always possible since we're using g_return_val_if_fail() in glib/gtk+ too...
Comment 3 Jan de Groot 2006-05-29 20:44:33 UTC 
Then the bug is in the lib that exports the call, as that one should set the error object. This patch prevents the clock applet from crashing, but it should be able to display an error message about a missing evolution-2.6 binary.
Comment 4 Sebastien Bacher 2006-09-02 09:32:31 UTC 
*** Bug 353809 has been marked as a duplicate of this bug. ***
Comment 5 Sebastien Bacher 2006-09-02 09:33:23 UTC 
Similar Ubuntu bug: https://launchpad.net/distros/ubuntu/+source/gnome-panel/+bug/58428

"If evolution is not installed, when double click a day in the clock applet, gnome-panel will crash.

Steps to reproduce:
1. sudo apt-get remove evolution
2. Click the the clock applet in the panel, it will show a calendar
3. Double-click a day
..."
Comment 6 lqs 2006-09-02 09:51:36 UTC 
Just initialize the variable `error' before calling gdk_spawn_command_line_on_screen. 
No need to check it after the call.
Comment 7 Vincent Untz 2006-09-04 06:57:46 UTC 
Good catch, it was not initialized.
Comment 8 Vincent Untz 2006-09-04 06:58:35 UTC 
Created attachment 72181 [details] [review]
Proposed patch
Comment 9 Vincent Untz 2006-09-04 19:15:18 UTC 
I committed the error = NULL; part.
The other part will go later.
Comment 10 André Klapper 2007-01-05 23:32:11 UTC 
*ping*
vincent: you set the patch at bug 340622 to accepted-commit_after_freeze on 2006-09-04 - can you please commit it now? :-)