After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 340410 - Various cleanups for ORBit2/linc
Various cleanups for ORBit2/linc
Status: RESOLVED FIXED
Product: ORBit2
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: ORBit maintainers
ORBit maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-02 15:02 UTC by Kjartan Maraas
Modified: 2006-05-04 17:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
cleanups (20.11 KB, patch)
2006-05-02 15:03 UTC, Kjartan Maraas 		none Details | Review

Description Kjartan Maraas 2006-05-02 15:02:38 UTC 
- remove unused variables and code
- fix format specifiers
- remove obsolete comment in configure.in
- remove redundant const markers in linc
- s/if/ifdef in some placess
- fix some typos
- mark some code as static
- fix use of wrong variable in test/echo-srv.c
Comment 1 Kjartan Maraas 2006-05-02 15:03:10 UTC 
Created attachment 64669 [details] [review]
cleanups
Comment 2 Michael Meeks 2006-05-02 16:50:16 UTC 
looks lovely to me - please do commit.
it'd also be great to bin the LINC_SSL_SUPPORT AC_SUBST in configure.in too.

Thanks.
Comment 3 Kjartan Maraas 2006-05-02 20:49:26 UTC 
Removed the ssl bits and commited.
Comment 4 Elijah Newren 2006-05-04 17:28:06 UTC 
This change caused bug 340532...