GNOME Bugzilla – Bug 340369
[volume element] "volume" property range insufficient
Last modified: 2006-05-03 13:33:58 UTC
Please describe the problem: The "volume" property in the volume element has the maximum value of 4. This could be insufficient in certain cases, i. e. when an audio file is very quiet, the media player will try to raise the volume using replaygain information. Together with pre-amplification, the requested value may exceed 4 or even 5. I suggest raising the "volume" property maximum value to 10. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
* gst/volume/gstvolume.c: (volume_funcfind), (volume_set_caps), (volume_transform_ip): Increase "volume" property to 10.0. Fixes #340369. Set the process function to NULL when capsnego fails so that we properly error out.
I originally had it at 4 for automatically-generated guis, so that you wouldn't get a slider too big. However I don't think bounds information like that should be mapped to property bounds; it would be more correct to make the range unlimited. That would fix this bug for good.