GNOME Bugzilla – Bug 340321
Nautilus should use Trash icon for Move to Trash menu items
Last modified: 2006-07-25 01:39:30 UTC
Nautilus currently uses GTK_STOCK_DELETE for the "Move to Trash" menu items in its UI. These should be replaced with the trash icon from the icon theme, as the delete icon should contain a different metaphor that does not imply that items are recoverable after being deleted. The attached patch does this by switching from GTK_STOCK_DELETE to "user-trash-empty" which is in the Icon Naming Specification and provided by gnome-icon-theme 2.15.x.
Created attachment 64629 [details] [review] Patch to use user-trash-empty rather than GTK_STOCK_DELETE
as pointed on https://launchpad.net/distros/ubuntu/+source/tangerine-icon-theme/+bug/45925 the icon of the context menu of the location button of the spatial mode needs to be changed too
Created attachment 68738 [details] [review] Updated patch to fix more uses of delete instead of trash
Is this better? Can we get it in soon? :)
Thanks, it's on HEAD: 2006-07-25 Martin Wehner <martin.wehner@gmail.com> * libnautilus-private/nautilus-icon-factory.c: * src/file-manager/fm-directory-view.c: * src/file-manager/fm-tree-view.c: (create_popup_menu): * src/nautilus-window-menus.c: Use trash icons from the icon naming specification for trash related operations. (#340321) Patch from Rodney Dawes <dobey@novell.com>
Rodney, what about bug # 332448 ('Delete from Trash' menu item should not have the trashcan icon) ?
Luca, that is a dup of #169451 I think. That menu item should be using GTK_STOCK_DELETE, but the icon is currently a trash icon, in the theme. We need to make this a better metaphor there.