After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 340094 - Space for names should be set according with the size of the icons
Space for names should be set according with the size of the icons
Status: RESOLVED OBSOLETE
Product: nautilus
Classification: Core
Component: Desktop
2.12.x
Other All
: Normal enhancement
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-29 06:45 UTC by Alejandro Andrés
Modified: 2018-01-02 18:46 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
There is the problem (20.27 KB, image/jpeg)
2006-04-29 08:06 UTC, Alejandro Andrés 		  Details
Solves the bug https://bugzilla.gnome.org/show_bug.cgi?id=340094 (780 bytes, patch)
2013-04-22 00:13 UTC, M S SURAJ 		none Details | Review
Fixes this bug. (933 bytes, patch)
2013-05-03 00:37 UTC, M S SURAJ 		rejected Details | Review

Description Alejandro Andrés 2006-04-29 06:45:29 UTC 
As said, if you resize an icon, the space below it for naming should be resized
accordingly.
Comment 1 Elijah Newren 2006-04-29 06:53:24 UTC 
I have no clue what you're talking about.  Care to provide a screenshot and use something like the gimp to circle what you're referring to?
Comment 2 Alejandro Andrés 2006-04-29 08:06:45 UTC 
Created attachment 64506 [details]
There is the problem

Sorry, i was busy and not able to upload the picture... you are fast! :)
Comment 3 Nelson Benitez 2006-09-10 02:21:36 UTC 
I can also see this bug. I noticed that zooming in/out does it well, adjusting the label according to the icon size, so stretch_icon could do it as well.
Comment 4 M S SURAJ 2013-04-22 00:13:48 UTC 
Created attachment 242111 [details] [review]
Solves the bug https://bugzilla.gnome.org/show_bug.cgi?id=340094

The patch modifies libnautilus-private/nautilus-canvas-item.c accordingly to fix the bug. I made it for nautilus 3.6.3
Comment 5 M S SURAJ 2013-05-03 00:37:36 UTC 
Created attachment 243130 [details] [review]
Fixes this bug.

PFA the patch for nautilus-3.8.1 that solves this bug.
Comment 6 Carlos Soriano 2016-02-29 14:53:34 UTC 
Review of attachment 243130 [details] [review]:

Thanks for the patch!

Sorry it took so long for reviewing. The code changed slightly (just a a constant) so the patch would need update.
Anyway, I'm not sure this is the right approach... is really the pixels_per_unit affected when manually editing the size of an icon?
Comment 7 António Fernandes 2017-08-18 08:01:48 UTC 
Review of attachment 243130 [details] [review]:

Rejecting the pending patch, as we are tying up loose ends on bugzilla before the transition to GitLab.

Also, nautilus-desktop will be soon be unsupported, so this would not get a followup anyway.
Comment 8 António Fernandes 2018-01-02 18:46:26 UTC 
Starting with version 3.28, nautilus will not handle the "files on desktop background" feature. For better alternatives, read this blog post https://csorianognome.wordpress.com/2017/12/21/nautilus-desktop-plans/