GNOME Bugzilla – Bug 339247
Crash during import while setting tags
Last modified: 2006-06-05 04:09:47 UTC
Please describe the problem: When importing some files changed by previous versions of f-spot, they don't get added. Steps to reproduce: 1. Open f-spot 2. Import some file already changed by f-spot 3. Nothing shows up regarding that file Actual results: The picture doesn't show, and no error is shown. I run f-spot in debug mode and the following shows: uri = file:///extra/d/Fotos/z20/Ferias_Algarve/10650819/pict0095%20(Modified).jpg Scanning /extra/d/Fotos/z20/Ferias_Algarve/10650819 loading exif data Error importing /extra/d/Fotos/z20/Ferias_Algarve/10650819/pict0095 (Modified).jpg System.ArgumentNullException: Argument cannot be null. Parameter name: src in <0x00000> <unknown method> in (wrapper managed-to-native) System.Runtime.InteropServices.Marshal:copy_from_unmanaged (intptr,int,System.Array,int) in <0x00013> System.Runtime.InteropServices.Marshal:Copy (IntPtr source, System.Byte[] destination, Int32 startIndex, Int32 length) in <0x00050> Exif.ExifEntry:get_Data () in <0x00054> FSpot.JpegFile:get_Description () in <0x0006d> PhotoStore:Create (System.String newPath, System.String origPath, Gdk.Pixbuf thumbnail) in <0x000cd> FileImportBackend:Step (.Photo photo, Gdk.Pixbuf thumbnail, System.Int32 count) Could not import file Stopping Reloading Expected results: The file is loaded, or some error regarding issues with the file/exif data of the file is shown. Does this happen every time? Yes Other information: The exif file for two photos, one that gets loaded (83) and the one that isn't, debug information shown above. EXIF tags in '/extra/d/Fotos/z20/Ferias_Algarve/10650819/pict0095 (Modified).jpg' ('Intel' byte order): --------------------+---------------------------------------------------------- Tag |Value --------------------+---------------------------------------------------------- Image Description |KONICA MINOLTA DIGITAL CAMERA Manufacturer |KONICA MINOLTA Model |DiMAGE Z20 Orientation |top - left x-Resolution |72.00 y-Resolution |72.00 Resolution Unit |Inch Software |f-spot version 0.1.3 Date and Time |2006:02:23 18:46:44 YCbCr Positioning |co-sited Compression |JPEG compression x-Resolution |72.00 y-Resolution |72.00 Resolution Unit |Inch Exposure Time |1/60 sec. FNumber |f/3.2 ExposureProgram |Portrait ISO Speed Ratings |160 Exif Version |Exif Version 2.2 Date and Time (origi|2005:08:19 22:07:26 Date and Time (digit|2005:08:19 22:07:26 ComponentsConfigurat|Y Cb Cr - Compressed Bits per |2.00 Brightness |37/10 Exposure Bias |0.0 MaxApertureValue |3.35 Metering Mode |Pattern Light Source |0 Flash |Flash fired, auto mode. Focal Length |9.2 mm Subject Area |Within rectangle (width 640, height 480) around (x,y) = ( Maker Note |820 bytes unknown data User Comment | FlashPixVersion |FlashPix Version 1.0 Color Space |sRGB PixelXDimension |2560 PixelYDimension |1920 File Source |DSC Scene Type | Custom Rendered |Normal process Exposure Mode |Auto exposure White Balance |Auto white balance Digital Zoom Ratio |0.00 Focal Length In 35mm|55 Scene Capture Type |Portrait Gain Control |Low gain up Contrast |Normal Saturation |Normal Sharpness |Normal Subject Distance Ran|Distant view InteroperabilityInde|R98 InteroperabilityVers| --------------------+---------------------------------------------------------- EXIF data contains a thumbnail (3688 bytes). EXIF tags in '/extra/d/Fotos/z20/Ferias_Algarve/10650819/pict0083.jpg' ('Intel' byte order): --------------------+---------------------------------------------------------- Tag |Value --------------------+---------------------------------------------------------- Image Description |KONICA MINOLTA DIGITAL CAMERA Manufacturer |KONICA MINOLTA Model |DiMAGE Z20 Orientation |top - left x-Resolution |72.00 y-Resolution |72.00 Resolution Unit |Inch Software |DiMAGE Z20 Ver1.00 Date and Time |2005:08:19 21:39:58 YCbCr Positioning |co-sited Compression |JPEG compression x-Resolution |72.00 y-Resolution |72.00 Resolution Unit |Inch Exposure Time |1/99 sec. FNumber |f/4.8 ExposureProgram |Manual ISO Speed Ratings |100 Exif Version |Exif Version 2.2 Date and Time (origi|2005:08:19 21:39:58 Date and Time (digit|2005:08:19 21:39:58 ComponentsConfigurat|Y Cb Cr - Compressed Bits per |2.00 Brightness |63/10 Exposure Bias |0.0 MaxApertureValue |3.35 Metering Mode |Pattern Light Source |0 Flash |Flash did not fire, compulsatory flash mode. Focal Length |48.0 mm Subject Area |Within rectangle (width 2560, height 1920) around (x,y) = Maker Note |820 bytes unknown data User Comment |Invalid size of entry (8, expected 0 x 1). FlashPixVersion |FlashPix Version 1.0 Color Space |sRGB PixelXDimension |2560 PixelYDimension |1920 File Source |DSC Scene Type | Custom Rendered |Normal process Exposure Mode |Manual exposure White Balance |Auto white balance Digital Zoom Ratio |4.00 Focal Length In 35mm|290 Scene Capture Type |Standard Gain Control |Normal Contrast |Normal Saturation |Normal Sharpness |Normal Subject Distance Ran|Distant view InteroperabilityInde|R98 InteroperabilityVers| --------------------+---------------------------------------------------------- EXIF data contains a thumbnail (1714 bytes).
Could you attach the photo that did not get added to F-Spot?
Created attachment 65680 [details] Picture with issues getting imported Well, the original picture was too big to attach, I scaled it with The Gimp and it still isn't imported to f-spot... I hope it helps.
I could import this picture without any problems. $ ./f-spot --version Gnome f-spot 0.1.11 Picture timestamp (from View Metadata) Date and Time (original) 2006:04:09 18:34:36
$ ./f-spot --version Gnome f-spot 0.1.11 Using latest CVS version (really wish we get Subversion soon!)
How did you import the picture? I have the same version (on Dapper): $ f-spot --version Gnome f-spot 0.1.11 ... just deleted the db, apt-get --purged the package and reinstalled and it gives me the same error... :( uri = file:///extra/d/Fotos/z20/10260409/test.JPG Scanning /extra/d/Fotos/z20/10260409 loading exif data Error importing /extra/d/Fotos/z20/10260409/test.JPG System.ArgumentNullException: Argument cannot be null. Parameter name: src in <0x00000> <unknown method> in (wrapper managed-to-native) System.Runtime.InteropServices.Marshal:copy_from_unmanaged (intptr,int,System.Array,int) in <0x00013> System.Runtime.InteropServices.Marshal:Copy (IntPtr source, System.Byte[] destination, Int32 startIndex, Int32 length) in <0x00050> Exif.ExifEntry:get_Data () in <0x00054> FSpot.JpegFile:get_Description () in <0x0006d> PhotoStore:Create (System.String newPath, System.String origPath, Gdk.Pixbuf thumbnail) in <0x000cd> FileImportBackend:Step (.Photo photo, Gdk.Pixbuf thumbnail, System.Int32 count) Could not import file Stopping Reloading
Could you try with CVS version? I am using CVS. (Really wish we had SVN now. With SVN you get a new version with every submits) ---- Set the CVS Root CVSROOT=":pserver:anonymous@anoncvs.gnome.org:/cvs/gnome" export CVSROOT Checkout the f-spot module cd ~/development cvs checkout f-spot Autogen and configure cd f-spot mkdir ~/home/<user>/unstable/f-spot ./autogen.sh --prefix=/home/<user>/unstable/f-spot Repeat the autogen, until all missing modules have been installed. Make make all install Update the module cvs update -dP
checking for F... configure: error: Package requirements (libgnome-2.0 >= 2.2 libgnomeui-2.0 >= 2.2 libexif >= 0.5.7 libexif < 0.7.0 gtkhtml-sharp-2.0 >= 2.7 gconf-sharp-2.0 >= 2.7 glade-sharp-2.0 >= 2.7 gnome-vfs-sharp-2.0 >= 2.7 gtk+-2.0 >= 2.6 mono >= 1.1.7 dbus-sharp >= 0.23) were not met: Package glitz was not found in the pkg-config search path. Perhaps you should add the directory containing `glitz.pc' to the PKG_CONFIG_PATH environment variable Package 'glitz', required by 'cairo', not found Consider adjusting the PKG_CONFIG_PATH environment variable if you installed software in a non-standard prefix. Alternatively, you may set the environment variables F_CFLAGS and F_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details. help? :)
Is it libglitz dev package that is missing? libglitz1-dev: Depends: libglitz1 (= 0.5.3-0ubuntu2) but 0.5.5-0ubuntu2 is to be installed :( If in cvs the bug seems to be solved, I believe we could close this bug as FIXED and move on. I'll wait for a package refresh or a backport shows in Dapper. Should I contact the package maintainer or something?
Ok, I have no problem importing the picture. But when I select it the following appears on the console: System.Exception: Invalid UserComment value, no charset found in <0x001f6> FSpot.Tiff.UserComment:.ctor (System.Byte[] raw_data, Boolean little) in <0x0003f> FSpot.Tiff.DirectoryEntry:get_UserCommentValue () in <0x00107> FSpot.Tiff.DirectoryEntry:get_ValueAsString () in <0x005a3> FSpot.Tiff.Header:SelectDirectory (FSpot.Tiff.ImageDirectory dir, StatementSink sink) in <0x00716> FSpot.Tiff.Header:SelectDirectory (FSpot.Tiff.ImageDirectory dir, StatementSink sink) If this can be confirmed by some other who has latest CVS, we can close this one. Perhaps open a new bug with above console error message.
Ok, Now I get the crash ! After removing CVS and fetching a fresh copy, I got the crash during import of this picture. (test.JPG) Bumping to Major You have to set a tag during the import, and then F-Spot crash and burn while setting the tag on this picture. Works fine to set tags/title after import though. System.NullReferenceException: Object reference not set to an instance of an object in <0x0003f> FSpot.JpegFile:get_ExifData () in <0x00022> FSpot.JpegFile:SetDescription (System.String value) in <0x000b0> Photo:WriteMetadataToImage () in <0x0007f> MainWindow:HandleDbItemsChanged (System.Object sender, .DbItemEventArgs args) in (wrapper delegate-invoke) System.MulticastDelegate:invoke_void_object_DbItemEventArgs (object,DbItemEventArgs) in <0x0001d> DbStore:EmitChanged (.DbItem[] items, .DbItemEventArgs args) in <0x0008c> PhotoStore:Commit (.DbItem[] items, .DbItemEventArgs args) in <0x0003f> PhotoStore:Commit (.DbItem item) in <0x005ed> ImportCommand:ImportFromFile (.PhotoStore store, System.String path) in <0x00054> MainWindow:HandleImportCommand (System.Object sender, System.EventArgs e) in (wrapper delegate-invoke) System.MulticastDelegate:invoke_void_object_EventArgs (object,System.EventArgs) in <0x00093> GLib.Signal:voidObjectCallback (IntPtr handle, IntPtr gch) in (wrapper native-to-managed) GLib.Signal:voidObjectCallback (intptr,intptr) i
the crash during import is fixed now. Is there still an issue with reading the UserComment?
There was an update package yesterday, which I installed. $ f-spot Starting new FSpot server uri = file:///extra/d/Fotos/z20/Ferias_Algarve/10650819/pict0095%20(Modified).jpg Scanning /extra/d/Fotos/z20/Ferias_Algarve/10650819 loading exif data Error importing /extra/d/Fotos/z20/Ferias_Algarve/10650819/pict0095 (Modified).jpg System.ArgumentNullException: Argument cannot be null. Parameter name: src in <0x00000> <unknown method> in (wrapper managed-to-native) System.Runtime.InteropServices.Marshal:copy_from_unmanaged (intptr,int,System.Array,int) in <0x00013> System.Runtime.InteropServices.Marshal:Copy (IntPtr source, System.Byte[] destination, Int32 startIndex, Int32 length) in <0x00050> Exif.ExifEntry:get_Data () in <0x00054> FSpot.JpegFile:get_Description () in <0x0006d> PhotoStore:Create (System.String newPath, System.String origPath, Gdk.Pixbuf thumbnail) in <0x000d5> FileImportBackend:Step (.Photo photo, Gdk.Pixbuf thumbnail, System.Int32 count) Could not import file Stopping Reloading And the pictures doesn't show up in the main window... :( This is a picture which was imported into an early version of f-spot and just rotated. The original gets imported, the rotated doesn't. This wouldn't be an issue if f-spot didn't changed some of my original pictures directly, and I can't import them in the current version (Dapper package).
There was an update package yesterday, which I installed. $ f-spot Starting new FSpot server uri = file:///extra/d/Fotos/z20/Ferias_Algarve/10650819/pict0095%20(Modified).jpg Scanning /extra/d/Fotos/z20/Ferias_Algarve/10650819 loading exif data Error importing /extra/d/Fotos/z20/Ferias_Algarve/10650819/pict0095 (Modified).jpg System.ArgumentNullException: Argument cannot be null. Parameter name: src in <0x00000> <unknown method> in (wrapper managed-to-native) System.Runtime.InteropServices.Marshal:copy_from_unmanaged (intptr,int,System.Array,int) in <0x00013> System.Runtime.InteropServices.Marshal:Copy (IntPtr source, System.Byte[] destination, Int32 startIndex, Int32 length) in <0x00050> Exif.ExifEntry:get_Data () in <0x00054> FSpot.JpegFile:get_Description () in <0x0006d> PhotoStore:Create (System.String newPath, System.String origPath, Gdk.Pixbuf thumbnail) in <0x000d5> FileImportBackend:Step (.Photo photo, Gdk.Pixbuf thumbnail, System.Int32 count) Could not import file Stopping Reloading And the pictures doesn't show up in the main window... :( This is a picture which was imported into an early version of f-spot and just rotated. The original gets imported, the rotated doesn't. This wouldn't be an issue if f-spot didn't changed some of my original pictures directly, and I can't import them in the current version (Dapper package).
trouble reading the orientaion shouldn't be fatal in the import process I'll look into it.
bruno, actually please open a new bug for the failure to import issue, the crash and it are unrelated and i don't want to combine the bugs.
ok I'm actually going to repopen this, there is more wrong here that I thought.
Just a note... the subject of the bug report was "Photos don't get imported", I never mentioned a crash... I just noticed that the subject changed to reference a crash... So, even if the crash was gone (if it happened to someone else) the importing issues remain. :) I've seen you found something wrong that can be related to my problem, I hope it leads you to a solution. ;) Cheers.
This looks like the same exception as in bug 334481.
Now that I look at it, that is the version in which I edited the pictures with troubles, closing as duplicate (since the other bug is older), feel free to change status if you like. On a side note, I don't know why I didn't find that bug before I reported this one. Thank you for bringing it to my attention. ;) *** This bug has been marked as a duplicate of 334481 ***