After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 339140 - [Patch] Use po/LINGUAS - based on the new guidelines
[Patch] Use po/LINGUAS - based on the new guidelines
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
git master
Other Linux
: Normal enhancement
: 2.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-20 09:37 UTC by Przemysław Grzegorczyk
Modified: 2006-07-27 03:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (1.21 KB, patch)
2006-04-20 09:38 UTC, Przemysław Grzegorczyk
accepted-commit_after_freeze Details | Review
Updated patch - intltool 0.35.0 released (1.21 KB, patch)
2006-05-15 18:14 UTC, Przemysław Grzegorczyk
none Details | Review
po-linguas.diff (2.67 KB, patch)
2006-07-12 11:13 UTC, Ruben Vermeersch
committed Details | Review

Description Przemysław Grzegorczyk 2006-04-20 09:37:12 UTC
Here is a patch based on the new guidelines (http://live.gnome.org/GnomeGoals/PoLinguas).
Comment 1 Przemysław Grzegorczyk 2006-04-20 09:38:09 UTC
Created attachment 63928 [details] [review]
Proposed patch
Comment 2 Ruben Vermeersch 2006-04-20 09:55:49 UTC
Patch looks good, but I'd hold back on committing this one for a while, even Ubuntu Dapper doesn't have intltool 0.34.90 yet, which basically means we'd limit our CVS users to those who run a CVS version of GNOME.

It should be noted that I've been half-out for a week, so things might have changed in the meantime, feel free to correct me if I'm wrong.
Comment 3 Aaron Bockover 2006-04-20 15:47:42 UTC
I don't particularly feel like making a CVS-intltool a build requirement right now. The current/old/hacky po/LINGUAS is fine with me for a while... it still acheives the goal of allowing translators to just check out po/

When 0.35 is out and more standard this will go in. Thanks.
Comment 4 Gabriel Burt 2006-05-02 03:03:34 UTC
This looks to be fixed in HEAD and the stable branch now.
Comment 5 Ruben Vermeersch 2006-05-02 09:23:48 UTC
It's not fixed yet, the new guidelines patch isn't in (yet). It'll go in when the new intltool is more common. 

Keeping it open till then.
Comment 6 Przemysław Grzegorczyk 2006-05-15 18:14:32 UTC
Created attachment 65523 [details] [review]
Updated patch - intltool 0.35.0 released
Comment 7 Ruben Vermeersch 2006-07-12 11:13:28 UTC
Created attachment 68806 [details] [review]
po-linguas.diff

Fixed patch to match current CVS. Intltool 0.35 has landed in Ubuntu Dapper (but I'm not sure other distro's have it). Should we get this in before 0.11.0?


Use intltool 0.35 for locale handling.

 ChangeLog    |    6 ++++++
 configure.ac |    4 +---
 po/ChangeLog |    4 ++++
 po/LINGUAS   |   25 ++++++++++++++++++++++++-
 4 files changed, 35 insertions(+), 4 deletions(-)
Comment 8 Ruben Vermeersch 2006-07-12 21:02:19 UTC
Marking patch accepted-commit_after_freeze until the new intltool becomes more widespread (at abocks advice).
Comment 9 Aaron Bockover 2006-07-27 03:47:01 UTC
Okay, went ahead and committed.