After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 338468 - display capplet does use deprecated GtkOptionMenu API
display capplet does use deprecated GtkOptionMenu API
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Display
git master
Other Linux
: Normal normal
: ---
Assigned To: Sven Herzberg
Control-Center Maintainers
Depends on:
Blocks: 324125
 
 
Reported: 2006-04-14 13:33 UTC by Sven Herzberg
Modified: 2006-07-06 14:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Prposed patch (tested) (6.15 KB, patch)
2006-04-14 13:34 UTC, Sven Herzberg 		accepted-commit_now Details | Review

Description Sven Herzberg 2006-04-14 13:33:09 UTC 
We should use the GtkComboBox API (which make some parts of the code even cleaner).
Comment 1 Sven Herzberg 2006-04-14 13:34:57 UTC 
Created attachment 63460 [details] [review]
Prposed patch (tested)
Comment 2 Sebastien Bacher 2006-07-06 09:20:08 UTC 
> +  GtkComboBox *combo = GTK_COMBO_BOX (screen_info->resolution_widget);
> +  GtkListStore* store = gtk_list_store_new(N_COLUMNS, G_TYPE_STRING, G_TYPE_INT);

Isn't that an issue for some compiler? Other way the patch looks fine, feel free to commit with that fixed
Comment 3 Sven Herzberg 2006-07-06 14:25:15 UTC 
2006-07-06  Sven Herzberg  <herzi@gnome-de.org>

        * capplets/display/main.c: replaced GtkOptionMenu by GtkComboBox;
        Closes: #338468