After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 337766 - deskbar-applet failed to parse epiphany's history
deskbar-applet failed to parse epiphany's history
Status: RESOLVED DUPLICATE of bug 739574
Product: libxml2
Classification: Platform
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Daniel Veillard
libxml QA maintainers
: 339681 364303 367867 373821 392777 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-04-09 04:07 UTC by Eddy Mulyono
Modified: 2017-06-14 11:50 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
snip of ephy-history.xml, line 20520..20530 (565 bytes, text/plain)
2006-04-09 04:13 UTC, Eddy Mulyono 		Details
Simplified code for saving (605 bytes, text/plain)
2006-04-14 19:21 UTC, Tommi Komulainen 		Details

Description Eddy Mulyono 2006-04-09 04:07:26 UTC 
Please describe the problem:
deskbar-applet (or python) failed to parse epiphany's ephy-history.xml when
given hex 0x0B (Vertical Tab).

Steps to reproduce:
Not sure, but try this:
1. Open http://norvig.com/Gettysburg/sld004.htm using Epiphany
2. Add deskbar-applet to panel



Actual results:
Traceback (most recent call last):

+ Trace 67543

  • File "/usr/lib/deskbar-applet/handlers/epiphany.py", line 66 in <lambda> 
    self.watcher.connect('changed', lambda watcher, f: self.watch_callback())
  • File "/usr/lib/deskbar-applet/handlers/epiphany.py", line 131 in _parse_history 
    self._history = EpiphanyHistoryParser(self, favicon_cache).get_indexer()
  • File "/usr/lib/deskbar-applet/handlers/epiphany.py", line 270 in __init__ 
    self._index_history();
  • File "/usr/lib/deskbar-applet/handlers/epiphany.py", line 282 in _index_history 
    parser.parse(EPHY_HISTORY_FILE)
  • File "/usr/lib/python2.4/site-packages/_xmlplus/sax/expatreader.py", line 109 in parse 
    xmlreader.IncrementalParser.parse(self, source)
  • File "/usr/lib/python2.4/site-packages/_xmlplus/sax/xmlreader.py", line 123 in parse 
    self.feed(buffer)
  • File "/usr/lib/python2.4/site-packages/_xmlplus/sax/expatreader.py", line 220 in feed 
    self._err_handler.fatalError(exc)
  • File "/usr/lib/python2.4/site-packages/_xmlplus/sax/handler.py", line 38 in fatalError 
    raise exception
SAXParseException: /home/eddy/.gnome2/epiphany/ephy-history.xml:20521:69: not 
well-formed (invalid token)

Parts of epiphany's history is searchable from deskbar-applet, but not
http://norvig.com/Gettysburg/sld004.htm. (I entered "success factors" and got
nothing).

Expected results:
All of epiphany's history is searchable from deskbar-applet, and no ugly dialog
box pops up.

Does this happen every time?
yes

Other information:
Comment 1 Eddy Mulyono 2006-04-09 04:13:57 UTC 
Created attachment 63003 [details]
snip of ephy-history.xml, line 20520..20530
Comment 2 Raphael Slinckx 2006-04-09 11:49:22 UTC 
I can reproduce here (nd it's really annoying ;))

I will see with ephy devs what's happening, since epiphany seems happy with the xml file..
Comment 3 Raphael Slinckx 2006-04-14 18:36:41 UTC 
Epiphany is also bailing out, to reproduce:
xmllint --noout ephy-history.xml

Assigning to libxml2 product
Comment 4 Tommi Komulainen 2006-04-14 19:21:11 UTC 
Created attachment 63495 [details]
Simplified code for saving

This is essentially the history saving code. Writes silently with no errors, fails on read.
Comment 5 Tommi Komulainen 2006-04-15 13:36:14 UTC 
Comment on attachment 63495 [details]
Simplified code for saving

Of course the real code has error handling done correctly unlike here... :-]
Comment 6 Daniel Veillard 2006-04-18 08:19:45 UTC 
You're writing a character which is not acceptable as an XML Character
this can't be escaped either.

Daniel
Comment 7 Raphael Slinckx 2006-04-29 09:02:30 UTC 
*** Bug 339681 has been marked as a duplicate of this bug. ***
Comment 8 Tommi Komulainen 2006-04-29 10:26:09 UTC 
So whose responsibility is it to handle escaping in this case? I'm expecting the "%s" take care of it (it works for <>&) but if it's caller's job, how can we know what needs escaping and what not?
Comment 9 Karsten Bräckelmann 2006-10-22 23:07:02 UTC 
*** Bug 364303 has been marked as a duplicate of this bug. ***
Comment 10 jamie 2006-10-31 11:08:13 UTC 
*** Bug 367867 has been marked as a duplicate of this bug. ***
Comment 11 jamie 2006-10-31 11:09:02 UTC 
*** Bug 367867 has been marked as a duplicate of this bug. ***
Comment 12 André Klapper 2006-11-12 03:07:42 UTC 
*** Bug 373821 has been marked as a duplicate of this bug. ***
Comment 13 Christian Persch 2007-01-04 16:08:40 UTC 
*** Bug 392777 has been marked as a duplicate of this bug. ***
Comment 14 Christophe Fergeau 2007-02-21 13:35:49 UTC 
Imo, even if that was an epiphany bug, deskbar shouldn't crash/display an error box because it failed to parse epiphany xml file. Dunno if the fact that this bug is still open means that something will be done on the deskbar side or not ;)
Comment 15 Nick Wellnhofer 2017-06-14 11:50:20 UTC 
Closing as duplicate of bug 739574 which some constructive dicussion.

*** This bug has been marked as a duplicate of bug 739574 ***