GNOME Bugzilla – Bug 337435
[PATCH] Update Automake & Autoconf macros
Last modified: 2006-05-22 15:09:12 UTC
Here's a patch to update automake, and use to use the package & version macros created by Autoconf. Since some of the files modified are from xchat, I'll send a patch to them tomorrow, so we aren't having to constantly repatch their files.
Created attachment 62825 [details] [review] Automake patch
Actually, the xchat-gnome build system is completely different from xchat's now (xchat's was way too messy). So no need to send them any patches.
I think it's customary to use GETTEXT_PACKAGE when referring to the translation domain, even if it happens to be the same as PACKAGE_NAME.
(In reply to comment #3) > I think it's customary to use GETTEXT_PACKAGE when referring to the translation > domain, even if it happens to be the same as PACKAGE_NAME. > Your right. Later today, I'll update the patch.
Created attachment 62864 [details] [review] Updated automake patch
I don't suppose you'd be willing to do this for xchat too? I'd like to keep the stuff in src/common as similar as possible.
Yeah, I thought comment #2 didn't make much sense. I should have some time later this week to work on a patch for xchat. When I'm finished, I'll link the xchat bug here.
Applied to svn, thanks!
(In reply to comment #0) > Here's a patch to update automake, and use to use the package & version macros > created by Autoconf. Since some of the files modified are from xchat, I'll > send a patch to them tomorrow, so we aren't having to constantly repatch their > files. > Brian, any feedback from xchat about your patch? It's very important because if it's not integrated, we could have a lot of problem the next time we sync (we'll forget this change for sure).
Looks like Zed committed my patch today. http://cia.navi.cx/stats/project/xchat/.message/4157e