After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 337234 - Obsolete code in proctime.c breaks the build under NetBSD
Obsolete code in proctime.c breaks the build under NetBSD
Status: RESOLVED FIXED
Product: libgtop
Classification: Core
Component: bsd
2.15.x
Other NetBSD
: Normal normal
: ---
Assigned To: libgtop maintainers
libgtop maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-04 17:48 UTC by Julio Merino
Modified: 2006-04-04 20:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Sample patch. (1.30 KB, patch)
2006-04-04 17:48 UTC, Julio Merino 		committed Details | Review

Description Julio Merino 2006-04-04 17:48:11 UTC 
There is a chunk of code in sysdeps/freebsd/proctime.c that breaks the build under NetBSD.  This block of code is guarded by a __NetBSD__ check so there is no fear that it can break other systems.

However, This piece of code refers to a variable, filename, that does not exist any more in the whole file.  Therefore it is safe to remove those lines because they are obsolete.  In fact, we have been doing this locally in NetBSD for a very long time with no visible problems.

Trivial patch attached.
Comment 1 Julio Merino 2006-04-04 17:48:38 UTC 
Created attachment 62752 [details] [review]
Sample patch.