GNOME Bugzilla – Bug 336837
[PATCH] Convert from popt to GOption
Last modified: 2007-05-10 13:27:50 UTC
For GNOME Goals (http://live.gnome.org/GnomeGoals/PoptGOption).
Created attachment 62540 [details] [review] Proposed patch
Committed.
I think we should have branched before this and commit to 2.15.x. But that's no harm, most of our users don't use the daemon ...
damn it, string breakage :/
no matter, popt is totally crap (cvs doesn't even pass configure. then it tries to do a lclint -I popt.c findme.c poptparse.c poptconfig.c popthelp.c ...). I'm going to get rid of that stuff right now !
benoît, can we branch and get this in now for gnome 2.17? thanks.
Any news about this?
Ping
I actually doubt that this patch has been tested has the libgtop_daemon is not built on linux.
benoît: means? why couldn't it have been tested on another operating system? do you want to say that somebody should test the patch on linux? michael: which operating system are you running? :-)
From a first glance, the patch looks good to me. GOption will also automatically call g_set_progname() for you, so there is no need to invoke it, but I assume it won't harm.
Woah, sorry for absence. I'm running Linux. I'm surprised that I would have proposed a patch on something I didn't test, but I was doing a lot of these patches at the time and probably felt confident in the change.
I am just saying that your patch modifies files that are not compiled on linux.
Yar, I believe it. If someone can test them on a non-Linux box or just review the heck out of it, I would be pleased.
so, how to continue here, folks? what is "non-linux"? solaris? bsd? anything?
freebsd is the priority. I don't have a computer nor the time to setup a FreeBSD GNOME devel env.
I poked some IRC channels. The task is to apply the patch and test if it compiles properly, no?
on ! linux, yes
As soon as i can resolv my git-svn troubles, i will svn commit the patch.
But it's still haven't been tested, not even compiled tested.
Ok, compiled and test, fixed, i also had to edit the Makefile.am. I will soon push changes on svn. Thanks. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.