After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 336610 - [PATCH] Convert from popt to GOption
[PATCH] Convert from popt to GOption
Status: RESOLVED FIXED
Product: bonobo
Classification: Deprecated
Component: libbonobo
CVS HEAD
Other Linux
: Normal normal
: ---
Assigned To: Michael Meeks
bonobo qa
Depends on:
Blocks:
 
 
Reported: 2006-03-30 12:51 UTC by Michael Terry
Modified: 2006-03-31 12:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (20.29 KB, patch)
2006-03-30 12:52 UTC, Michael Terry 		none Details | Review

Description Michael Terry 2006-03-30 12:51:17 UTC 
For GNOME Goals (http://live.gnome.org/GnomeGoals/PoptGOption).

A couple notes:
* I left in the configure requirement/check for popt because we export popt options in the public bonobo-activation-init.h header.
* Should we mark the exported 'bonobo_activation_popt_options' as deprecated?
* It looks like utils/bonobo-activate.c isn't used.  I converted it, but it isn't built.  A candidate for cvs remove?
Comment 1 Michael Terry 2006-03-30 12:52:03 UTC 
Created attachment 62386 [details] [review]
Proposed patch
Comment 2 Christian Persch 2006-03-30 13:14:39 UTC 
+++ activation-server/activation-server-main.c
"od-source-dir" looks like it should use G_OPTION_ARG_FILENAME instead of STRING.

+++ activation-server/client.c
Same for "add-path", "remove-path".

+++ utils/bonobo-activation-sysconf.c
add_directory callback gets a filename (G_OPTION_FLAG_FILENAME used), but searched for it in and adds the directory to the XML document without charset conversion... (also the function doesn't handle doc==NULL correctly, but that's outside the scope of this bug).
m.m. for remove_directory.
Comment 3 Michael Meeks 2006-03-31 08:45:31 UTC 
Michael - patch looks like a lovely cleanuup - thanks for that ! :-)

Lets bin utils/bonobo-activate.c as you suggest.

With chpe's fixes - can you commit to HEAD ?
Comment 4 Michael Terry 2006-03-31 12:02:07 UTC 
Committed to HEAD with chpe's fixes.