After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 336307 - Migrate to goption
Migrate to goption
Status: RESOLVED FIXED
Product: GConf
Classification: Deprecated
Component: gconf
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GConf Maintainers
GConf Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-03-28 07:51 UTC by Vincent Untz
Modified: 2006-08-07 10:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (22.34 KB, patch)
2006-03-28 07:52 UTC, Vincent Untz 		none Details | Review
New patch, without popt linking (24.18 KB, patch)
2006-03-30 19:58 UTC, Vincent Untz 		accepted-commit_now Details | Review
don't link popt (840 bytes, patch)
2006-07-31 20:38 UTC, William Jon McCann 		none Details | Review

Description Vincent Untz 2006-03-28 07:51:32 UTC 
Here's a patch to use GOption instead of popt.

There's a small regression: running "gconftool-2" (without any options) doesn't display the usage any more. I don't think we can do this with GOption :/

It probably needs some testing/verification since I didn't test all options of gconftool-2.
Comment 1 Vincent Untz 2006-03-28 07:52:13 UTC 
Created attachment 62183 [details] [review]
patch
Comment 2 Vincent Untz 2006-03-28 07:53:25 UTC 
Note that we can't really remove the popt dependency since there's the gconf_options variable in gconf.h, which is part of the API.
Comment 3 Matthias Clasen 2006-03-30 19:23:08 UTC 
you don't need to link against popt, at least.
Comment 4 Vincent Untz 2006-03-30 19:58:41 UTC 
Created attachment 62415 [details] [review]
New patch, without popt linking

Matthias: oh, good point. Here's a new patch.
Comment 5 Mark McLoughlin 2006-05-04 19:24:23 UTC 
Haven't reviewed in detail, but looks reasonable. Please commit
Comment 6 Kjartan Maraas 2006-05-05 13:49:14 UTC 
Commiting since Vincent didn't have time right now :-)
Comment 7 Alexander Larsson 2006-07-07 09:08:49 UTC 
It still links to libpopt. I get a "LIBS = -lpopt" line in Makefile that is causing it to get pulled in.,
Comment 8 William Jon McCann 2006-07-31 20:38:45 UTC 
Created attachment 70001 [details] [review]
don't link popt

This should stop linking to popt.  Look OK?
Comment 9 Alexander Larsson 2006-08-07 08:51:20 UTC 
Looks good to me, but I'm not the maintainer. We should try to get it in though.
Comment 10 Alexander Larsson 2006-08-07 10:19:29 UTC 
Commited.