Created attachment 62090 [details] [review]
patch

This turns DAAP into a plugin, the same way that audioscrobbler is.

NOTE: this requires removing the daap-specific hacks from rb-player-gst. Until we fix the daap source element to do real seeking, this probably can't be committed.

If we start converting features like this into plugins (which I think is a good idea, on the whole), I think we'll need to sort out a way to have them default to being enabled until the user explicitly disables them.

I forgot to do some gconf schema changes for that patch.

We can make daap support enabled by default, simply by setting the default of the key /apps/rhythmbox/plugins/daap/active to true.

Created attachment 75834 [details] [review]
updated

Updated to current CVS, added gconf schema stuff, disable DAAP with gstreamer 0.8 (since we won't have the player backend hacks for it, and no one seemed to notice it'd been broken for a while recently)

Looks okay to me, with the exception of the plugin being hidden. It has configuration options, so we need it visible for people to change them.

Created attachment 75987 [details] [review]
updated again

fixes plugin hiddenness, moves the non source specific stuff (mdns, icons, etc.)from rb-daap-source.c to rb-daap-plugin.c.

Looks fine to me.

OK, committed.