GNOME Bugzilla – Bug 336065
Nautilus should use GOption API
Last modified: 2006-05-18 13:44:54 UTC
I'm working on this. Adding this bug for tracking purposes
Created attachment 62023 [details] [review] First attempt. Might not compile. Added for tracking reasons This version of the patch might not compile. I'm testing it now. Adding this patch for tracking purposes. If/Once it works, I'll attach a new path with a ChangeLog entry.
Created attachment 62024 [details] [review] This version also compiles This version also actually compiles. I'm going to test functionality and once it works I'll attach a new path with ChangeLog entry yadi yada.
Created attachment 62025 [details] [review] This version also compiles This version also actually compiles. I'm going to test functionality and once it works I'll attach a new path with ChangeLog entry yadi yada.
Comment #3 is a negative. The const gchar **remaining is not left to NULL if the G_OPTION_REMAINING isn't used. Fixing this. Don't commit, yet.
Reply to Comment #4: By simply initializing the const gchar **remaining using =NULL, this problem is solved. Adding a new attachment with ChangeLog entry.
Created attachment 62026 [details] [review] Tested and added ChangeLog entry This one works. Please review and tell me when/if I can/may commit this.
FYI, A few simple quick-tests: pvanhoof@lort:~/repos/gnome/cvs/nautilus$ /opt/nautilus/bin/nautilus --restart test nautilus: --restart cannot be used with URIs. pvanhoof@lort:~/repos/gnome/cvs/nautilus$ /opt/nautilus/bin/nautilus --restart pvanhoof@lort:~/repos/gnome/cvs/nautilus$ /opt/nautilus/bin/nautilus --help Usage: nautilus [OPTION...] [URI...] Nautilus Help Options: -?, --help Show help options --help-all Show all help options --help-gtk Show GTK+ Options --help-bonobo-activation Show Bonobo Activation options --help-gnome Show GNOME options --help-gnome-session Show session management options --help-gnome-ui Show GNOME GUI options Application Options: -c, --check Perform a quick set of self-check tests. -g, --geometry=GEOMETRY Create the initial window with the given geometry. -n, --no-default-window Only create windows for explicitly specified URIs. --no-desktop Do not manage the desktop (ignore the preference set in the preferences dialog). --browser open a browser window. -q, --quit Quit Nautilus. --restart Restart Nautilus. --display=DISPLAY X display to use pvanhoof@lort:~/repos/gnome/cvs/nautilus$ /opt/nautilus/bin/nautilus --help-all Usage: nautilus [OPTION...] [URI...] Nautilus Help Options: -?, --help Show help options --help-all Show all help options --help-gtk Show GTK+ Options --help-bonobo-activation Show Bonobo Activation options --help-gnome Show GNOME options --help-gnome-session Show session management options --help-gnome-ui Show GNOME GUI options GTK+ Options --class=CLASS Program class as used by the window manager --name=NAME Program name as used by the window manager --screen=SCREEN X screen to use --sync Make X calls synchronous --gtk-module=MODULES Load additional GTK+ modules --g-fatal-warnings Make all warnings fatal Bonobo Activation --oaf-ior-fd=FD File descriptor to print IOR on --oaf-activate-iid=IID IID to activate --oaf-private Prevent registering of server with OAF GNOME Library --disable-sound Disable sound server usage --enable-sound Enable sound server usage --espeaker=HOSTNAME:PORT Host:port on which the sound server to use is running --version 2.14.0 Session management --sm-client-id=ID Specify session management ID --sm-config-prefix=PREFIX Specify prefix of saved configuration --sm-disable Disable connection to session manager GNOME GUI Library --disable-crash-dialog Disable Crash Dialog Application Options: -c, --check Perform a quick set of self-check tests. -g, --geometry=GEOMETRY Create the initial window with the given geometry. -n, --no-default-window Only create windows for explicitly specified URIs. --no-desktop Do not manage the desktop (ignore the preference set in the preferences dialog). --browser open a browser window. -q, --quit Quit Nautilus. --restart Restart Nautilus. --display=DISPLAY X display to use pvanhoof@lort:~/repos/gnome/cvs/nautilus$
Adding a depends. Claudio raises an interesting question in that Bug #336085.
As Bug #336085 talks about the string to use in the g_option_context function, I now need to know which string the nautilus authors would like. It shouldn't be "Nautilus" but something like "The filemanager".
Changing priority field and changing status to NEEDINFO. I'd like to know which string should be used and whether or not it's okay to commit this in CVS.
I commited this with some fixes and made nautilus-connect-to-server use goption too.